Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

LinearSelector #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 18, 2023
Merged

LinearSelector #168

merged 18 commits into from
Apr 18, 2023

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Apr 17, 2023

revamped LineSlider, renamed to LinearSelector

closes #162

  • responds to mouse events for drag and go to mouse wheel click location
  • can communicate with ipywidget slider
  • can make ipywidget slider
  • add_linear_selector(), for Line and LineCollection
  • move to new graphics.selectors module
  • Sychronizer

to do later:

  • test y axis
  • base Selector class and allow Synchronizer to work with all types of selectors

"side effects"

  • Graphic.__eq__() is necessary since these are weakref proxies since improve garbage collection #159 . So we must use graphic_a == graphic_b to check if they are the same object, is does ot work anymore!
  • renamed PlotArea._sliders to _selectors
line-slider-2023-04-17_04.46.43.mp4

Collections and sychronization:

line-slider-collection-2023-04-18_03.15.53.mp4

@EricThomson @ArjunPutcha thoughts?

@kushalkolar kushalkolar requested a review from clewis7 April 17, 2023 08:58
LinearRegionSelector, can select on x or y axis
entire selection responds to mouse events
edges allow resizing with mouse events, edges change color and thickness with interaction
`LinearSelector.get_selected_data()` returns a view of the data, or a list of views if from a collection such as LineStack
`LinearBoundsFeature` manages events.
`LineGraphic.add_linear_region_selector()`, allows adding multiple selectors onto the same graphic
`LineCollection.add_linear_region_selector()`
@kushalkolar kushalkolar changed the title Line slider improvements LinearSelector Apr 18, 2023
@kushalkolar kushalkolar merged commit 4e53ea7 into master Apr 18, 2023
@kushalkolar kushalkolar mentioned this pull request May 6, 2023
7 tasks
@kushalkolar kushalkolar deleted the line-slider-improvements branch May 23, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineSlider improvements
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.