Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

improve garbage collection #159

Copy link
Copy link
Closed
Closed
Copy link
@kushalkolar

Description

@kushalkolar
Issue body actions

Currently garbage collection doesn't seem to be working properly, if a world object is removed from the scene and deleted the GPU VRAM is not freed. However it seems like if we remove objects from a scene and delete them just through pygfx the GPU VRAM is freed. Should probably use weakreferences in our Graphic classes.

Run this, and then after the image is removed from the scene if you click or move the mouse on the canvas it will free up the GPU VRAM.

import numpy as np
from wgpu.gui.auto import WgpuCanvas, run
import pygfx as gfx
from weakref import
import subprocess

canvas = WgpuCanvas()
renderer = gfx.WgpuRenderer(canvas)
scene = gfx.Scene()
camera = gfx.OrthographicCamera(5000, 5000)
camera.position.x = 2048
camera.position.y = 2048


def make_image():
    data = np.random.rand(4096, 4096).astype(np.float32)

    return gfx.Image(
        gfx.Geometry(grid=gfx.Texture(data, dim=2)),
        gfx.ImageBasicMaterial(clim=(0, 1)),
    )

def draw():
    renderer.render(scene, camera)
    canvas.request_draw()


def print_nvidia(msg):
    print(msg)
    print(
        subprocess.check_output(["nvidia-smi", "--format=csv", "--query-gpu=memory.used"]).decode().split("\n")[1]
    )
    print()


def add_img(*args):
    print_nvidia("Before creating image")
    img = make_image()
    print_nvidia("After creating image")
    scene.add(img)
    img.add_event_handler(remove_img, "click")
    draw()
    print_nvidia("After add image to scene")


def remove_img(*args):
    img = scene.children[0]
    scene.remove(img)
    draw()
    print_nvidia("After remove image from scene")
    del img
    draw()
    canvas.ev
    print_nvidia("After del image")


renderer.add_event_handler(add_img, "double_click")

draw()
run()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.