Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

🐛 Fix Pydantic version check for version 2.10.x onwards #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

asiunov
Copy link
Contributor

@asiunov asiunov commented Dec 23, 2024

The pydantic version check works incorrectly since the release of pydantic 2.10.* ("2.10.0" < "2.7.0")

@svlandeg svlandeg self-assigned this Feb 20, 2025
@svlandeg svlandeg added the bug Something isn't working label Feb 20, 2025
@svlandeg svlandeg changed the title Fix context in model_dump for pydantic 2.10 🐛 Fix Pydantic version check for version 2.10.x onwards Feb 20, 2025
@svlandeg svlandeg removed their assignment Feb 20, 2025
sqlmodel/_compat.py Outdated Show resolved Hide resolved
sqlmodel/_compat.py Outdated Show resolved Hide resolved
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @asiunov! ☕

And thanks @svlandeg! 🍰

@tiangolo tiangolo merged commit 69a4504 into fastapi:main Feb 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.