Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e29e1f9

Browse filesBrowse files
lynnshaoyufacebook-github-bot
authored andcommitted
add enabledProvider argument inside @exec_time_resolvers directive (runtime + artifacts)
Reviewed By: tyao1 Differential Revision: D69763472 fbshipit-source-id: 6dcebf4dcec127ca17f5d762a991c38c7d66b699
1 parent 322d60a commit e29e1f9
Copy full SHA for e29e1f9

6 files changed

+574-24Lines changed: 574 additions & 24 deletions
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/relay-runtime/store/RelayReader.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/store/RelayReader.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,10 @@ class RelayReader {
132132
this._fieldErrors = null;
133133
this._owner = selector.owner;
134134
this._useExecTimeResolvers =
135-
this._owner.node.operation.use_exec_time_resolvers ?? false;
135+
this._owner.node.operation.use_exec_time_resolvers ??
136+
this._owner.node.operation.exec_time_resolvers_enabled_provider?.get() ===
137+
true ??
138+
false;
136139
this._recordSource = recordSource;
137140
this._seenRecords = new Set();
138141
this._selector = selector;
Collapse file

‎packages/relay-runtime/store/__tests__/RelayReader-ExecResolvers-test.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/store/__tests__/RelayReader-ExecResolvers-test.js
+79-2Lines changed: 79 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,12 @@ export function RelayReaderExecResolversTest_user_one(): IdOf<'RelayReaderExecRe
9494
* not as read time resolver queries.
9595
*/
9696
describe('RelayReaderExecResolvers', () => {
97-
it('reads exec_time_resolvers without calling the resolvers', () => {
97+
it('reads exec_time_resolvers without calling the resolvers when provider returns true', () => {
9898
const Query = graphql`
99-
query RelayReaderExecResolversTestRunsQuery @exec_time_resolvers {
99+
query RelayReaderExecResolversTestRunsQuery
100+
@exec_time_resolvers(
101+
enabledProvider: "relayReaderTestExecTimeResolversTrueProvider"
102+
) {
100103
RelayReaderExecResolversTest_user_one {
101104
name
102105
best_friend {
@@ -151,4 +154,78 @@ describe('RelayReaderExecResolvers', () => {
151154
},
152155
});
153156
});
157+
158+
it('reads read time resolvers when exec time resolvers provider returns false', () => {
159+
const Query = graphql`
160+
query RelayReaderExecResolversTestRunsNoProviderQuery
161+
@exec_time_resolvers(
162+
enabledProvider: "relayReaderTestExecTimeResolversFalseProvider"
163+
) {
164+
RelayReaderExecResolversTest_user_one {
165+
name
166+
best_friend {
167+
name
168+
}
169+
friends {
170+
name
171+
}
172+
}
173+
}
174+
`;
175+
const operation = createOperationDescriptor(Query, {});
176+
const source = new RelayRecordSource({
177+
'client:root': {
178+
__id: 'client:root',
179+
__typename: '__Root',
180+
RelayReaderExecResolversTest_user_one: {__ref: '1'},
181+
},
182+
'1': {
183+
__id: '1',
184+
name: 'Alice',
185+
friends: {__refs: ['2', '3', '4']},
186+
},
187+
'2': {
188+
__id: '2',
189+
name: 'Bob',
190+
},
191+
'3': {
192+
__id: '3',
193+
name: 'Claire',
194+
},
195+
'4': {
196+
__id: '4',
197+
name: 'Dennis',
198+
},
199+
});
200+
const resolverStore = new RelayModernStore(source);
201+
const {data} = read(
202+
source,
203+
operation.fragment,
204+
new LiveResolverCache(() => source, resolverStore),
205+
);
206+
207+
expect(modelMock).toBeCalled();
208+
expect(nameMock).toBeCalled();
209+
expect(user_oneMock).toBeCalled();
210+
expect(friendsMock).toBeCalled();
211+
expect(data).toEqual({
212+
RelayReaderExecResolversTest_user_one: {
213+
best_friend: {
214+
name: 'Bob',
215+
},
216+
friends: [
217+
{
218+
name: 'Bob',
219+
},
220+
{
221+
name: 'Claire',
222+
},
223+
{
224+
name: 'Dennis',
225+
},
226+
],
227+
name: 'Alice',
228+
},
229+
});
230+
});
154231
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.