Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b270988

Browse filesBrowse files
captbaritonefacebook-github-bot
authored andcommitted
Fix incremental bug where resolver artifacts were not cleaned up
Reviewed By: tyao1 Differential Revision: D75359233 fbshipit-source-id: 4d9b1861b110b4c2ef9b9127fd34eed8a417f106
1 parent a6f0fb3 commit b270988
Copy full SHA for b270988

1 file changed

+7-4Lines changed: 7 additions & 4 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎compiler/crates/relay-compiler/src/compiler.rs‎

Copy file name to clipboardExpand all lines: compiler/crates/relay-compiler/src/compiler.rs
+7-4Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -500,12 +500,15 @@ fn get_removed_docblock_artifact_source_keys(
500500
fn get_removed_full_sources(full_sources: Option<&FullSources>) -> Vec<ArtifactSourceKey> {
501501
let mut removed_full_sources: Vec<ArtifactSourceKey> = vec![];
502502
if let Some(full_sources) = full_sources {
503-
for (file, source) in full_sources.pending.iter() {
504-
if source.is_empty() {
505-
if let Some(text) = full_sources.processed.get(file) {
503+
for (file, pending_source_text) in full_sources.pending.iter() {
504+
if let Some(processed_source_text) = full_sources.processed.get(file) {
505+
// Full sources are keyed by a hash of their contents.
506+
// Therefore if the contents of a file have changed we must
507+
// treat the hash of the old version of that file as removed.
508+
if pending_source_text != processed_source_text {
506509
// For now, full sources are only used for ResolverHash
507510
removed_full_sources.push(ArtifactSourceKey::ResolverHash(
508-
ResolverSourceHash::new(text),
511+
ResolverSourceHash::new(processed_source_text),
509512
))
510513
}
511514
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.