facebook
diff --git a/Collapse file
‎compiler/crates/relay-bin/src/main.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-bin/src/main.rs
+2Lines changed: 2 additions & 0 deletions b/Collapse file
‎compiler/crates/relay-bin/src/main.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-bin/src/main.rs
+2Lines changed: 2 additions & 0 deletions
diff --git a/Collapse file
‎compiler/crates/relay-lsp/src/goto_definition.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-lsp/src/goto_definition.rs
+8-2Lines changed: 8 additions & 2 deletions b/Collapse file
‎compiler/crates/relay-lsp/src/goto_definition.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-lsp/src/goto_definition.rs
+8-2Lines changed: 8 additions & 2 deletions
diff --git a/Collapse file
‎compiler/crates/relay-lsp/src/lsp_extra_data_provider.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-lsp/src/lsp_extra_data_provider.rs
+1Lines changed: 1 addition & 0 deletions b/Collapse file
‎compiler/crates/relay-lsp/src/lsp_extra_data_provider.rs‎
Copy file name to clipboardExpand all lines: compiler/crates/relay-lsp/src/lsp_extra_data_provider.rs
+1Lines changed: 1 addition & 0 deletions
@@ -409,10 +409,12 @@ impl LSPExtraDataProvider for ExtraDataProvider {
         }
         let file_path = result[0];
         let line_number = result[1].parse::<u64>().unwrap() - 1;
+        let column_number = result[2].parse::<u64>().unwrap_or(1_u64) - 1;
 
         Ok(Some(FieldDefinitionSourceInfo {
             file_path: file_path.to_string(),
             line_number,
+            column_number,
             is_local: true,
         }))
     }
 
@@ -202,6 +202,7 @@ fn locate_type_definition(
             GotoDefinitionResponse::Scalar(get_location(
                 &source_info.file_path,
                 source_info.line_number,
+                source_info.column_number,
             )?)
         } else {
             return Err(LSPRuntimeError::ExpectedError);
@@ -318,6 +319,7 @@ fn locate_field_definition(
                 return Ok(GotoDefinitionResponse::Scalar(get_location(
                     &source_info.file_path,
                     source_info.line_number,
+                    source_info.column_number,
                 )?));
             } else {
                 error!(
@@ -345,10 +347,14 @@ fn locate_field_definition(
         .map_err(|_| LSPRuntimeError::ExpectedError)
 }
 
-fn get_location(path: &str, line: u64) -> Result<lsp_types::Location, LSPRuntimeError> {
+fn get_location(
+    path: &str,
+    line: u64,
+    column: u64,
+) -> Result<lsp_types::Location, LSPRuntimeError> {
     let start = lsp_types::Position {
         line: line as u32,
-        character: 0,
+        character: column as u32,
     };
     let range = lsp_types::Range { start, end: start };
 
 
@@ -12,6 +12,7 @@ use serde::Serialize;
 pub struct FieldDefinitionSourceInfo {
     pub file_path: String,
     pub line_number: u64,
+    pub column_number: u64,
     pub is_local: bool,
 }
Original file line number	Diff line number	Diff line change
`@@ -409,10 +409,12 @@ impl LSPExtraDataProvider for ExtraDataProvider {`
`409`	`409`	`}`
`410`	`410`	`let file_path = result[0];`
`411`	`411`	`let line_number = result[1].parse::<u64>().unwrap() - 1;`
	`412`	`+ let column_number = result[2].parse::<u64>().unwrap_or(1_u64) - 1;`
`412`	`413`
`413`	`414`	`Ok(Some(FieldDefinitionSourceInfo {`
`414`	`415`	`file_path: file_path.to_string(),`
`415`	`416`	`line_number,`
	`417`	`+ column_number,`
`416`	`418`	`is_local: true,`
`417`	`419`	`}))`
`418`	`420`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ use serde::Serialize;`
`12`	`12`	`pub struct FieldDefinitionSourceInfo {`
`13`	`13`	`pub file_path: String,`
`14`	`14`	`pub line_number: u64,`
	`15`	`+ pub column_number: u64,`
`15`	`16`	`pub is_local: bool,`
`16`	`17`	`}`
`17`	`18`