Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 134aea4

Browse filesBrowse files
itamarkfacebook-github-bot
authored andcommitted
Add error message to Resolver error
Reviewed By: captbaritone Differential Revision: D69417013 fbshipit-source-id: 21210134e2106494977b8d4e1a3b7654598b538a
1 parent 264e821 commit 134aea4
Copy full SHA for 134aea4

4 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/relay-runtime/store/__tests__/observeFragment-test.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/store/__tests__/observeFragment-test.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ test('Resolver error with @throwOnFieldError', async () => {
259259
expect(results).toEqual([
260260
{
261261
error: new Error(
262-
"Relay: Resolver error at path 'always_throws' in 'observeFragmentTestResolverErrorWithThrowOnFieldErrorFragment'.",
262+
"Relay: Resolver error at path 'always_throws' in 'observeFragmentTestResolverErrorWithThrowOnFieldErrorFragment'. Message: I always throw. What did you expect?",
263263
),
264264
state: 'error',
265265
},
@@ -541,7 +541,7 @@ test('Resolver error with @relay(plural: true) @throwOnFieldError', async () =>
541541
expect(results).toEqual([
542542
{
543543
error: new Error(
544-
"Relay: Resolver error at path 'always_throws' in 'observeFragmentTestResolverErrorWithPluralThrowOnFieldErrorFragment'.",
544+
"Relay: Resolver error at path 'always_throws' in 'observeFragmentTestResolverErrorWithPluralThrowOnFieldErrorFragment'. Message: I always throw. What did you expect?",
545545
),
546546
state: 'error',
547547
},
Collapse file

‎packages/relay-runtime/store/__tests__/waitForFragmentData-test.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/store/__tests__/waitForFragmentData-test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ test('Promise rejects with @throwOnFieldError', async () => {
116116
result = e;
117117
}
118118
expect(result?.message).toEqual(
119-
"Relay: Resolver error at path 'always_throws' in 'waitForFragmentDataTestResolverErrorWithThrowOnFieldErrorFragment'.",
119+
"Relay: Resolver error at path 'always_throws' in 'waitForFragmentDataTestResolverErrorWithThrowOnFieldErrorFragment'. Message: I always throw. What did you expect?",
120120
);
121121
});
122122

Collapse file

‎packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ describe('handlePotentialSnapshotErrors', () => {
387387
},
388388
]);
389389
}).toThrowError(
390-
/^Relay: Resolver error at path 'testPath' in 'testOwner'/,
390+
"Relay: Resolver error at path 'testPath' in 'testOwner'. Message: testError",
391391
);
392392

393393
expect(relayFieldLogger).toHaveBeenCalledTimes(1);
Collapse file

‎packages/relay-runtime/util/handlePotentialSnapshotErrors.js‎

Copy file name to clipboardExpand all lines: packages/relay-runtime/util/handlePotentialSnapshotErrors.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function handleFieldErrors(
3535
switch (fieldError.kind) {
3636
case 'relay_resolver.error':
3737
throw new Error(
38-
`Relay: Resolver error at path '${fieldError.fieldPath}' in '${fieldError.owner}'.`,
38+
`Relay: Resolver error at path '${fieldError.fieldPath}' in '${fieldError.owner}'. Message: ${fieldError.error.message}`,
3939
);
4040
case 'relay_field_payload.error':
4141
throw new Error(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.