[Repo Assist] [JS/TS] Add regression tests for N0, C0, P0 format specifiers#4450
Draft
github-actions[bot] wants to merge 1 commit into
mainfable-compiler/Fable:mainfrom
repo-assist/test-zero-precision-formats-f3aa41904be9487bfable-compiler/Fable:repo-assist/test-zero-precision-formats-f3aa41904be9487bCopy head branch name to clipboard
Draft
[Repo Assist] [JS/TS] Add regression tests for N0, C0, P0 format specifiers#4450github-actions[bot] wants to merge 1 commit intomainfable-compiler/Fable:mainfrom repo-assist/test-zero-precision-formats-f3aa41904be9487bfable-compiler/Fable:repo-assist/test-zero-precision-formats-f3aa41904be9487bCopy head branch name to clipboard
github-actions[bot] wants to merge 1 commit into
mainfable-compiler/Fable:mainfrom
repo-assist/test-zero-precision-formats-f3aa41904be9487bfable-compiler/Fable:repo-assist/test-zero-precision-formats-f3aa41904be9487bCopy head branch name to clipboard
Conversation
Add tests to prevent regressions for the trailing-dot bugs in N0, C0, and P0 numeric format specifiers (related to #2582). These test cases were previously missing from ConvertTests.fs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 27, 2026
24 tasks
MangelMaxime
force-pushed
the
main
branch
2 times, most recently
from
June 30, 2026 21:38
7ceced2 to
c85af32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
N0,C0, andP0test cases toConvertTests.fs"255."instead of"255","¤255."instead of"¤255") fixed in Format specifies don't seem to be fully implemented #2582 to go undetectedMotivation
The existing
ToStringformat tests coverN2,N15,N(default) but notN0. Likewise forCandP. Adding zero-precision cases ensures the precision-0 branches inString.tsremain correct if refactored.Test plan
./build.sh test javascript— new test cases pass./build.sh test typescript— new test cases pass🤖 Generated with Repo Assist
Note
🔒 Integrity filtering filtered 100 items
Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.
list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)EntryPoint#2366 (list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)