Handle empty parameters in prepared statement execution#230
Open
zag2me wants to merge 1 commit into
Open
Handle empty parameters in prepared statement execution#230zag2me wants to merge 1 commit into
zag2me wants to merge 1 commit into
Conversation
Add check for empty parameters before executing statement. query_prepared() now safely executes queries with no bound params instead of crashing on empty bind_param() types
Contributor
TheTechsTech
left a comment
There was a problem hiding this comment.
You need to provide something reproducible that will crash.
The query_prepared call allows for $param to be null.
You not fixing any real issue, seems to be creating one instead.
What are you writing that allows it to be or could be null/empty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for empty parameters before executing statement. query_prepared() now safely executes queries with no bound params instead of crashing on empty bind_param() types