Upgrade "content-type" - #728
#728Upgrade "content-type"#728Phillip9587 merged 5 commits intomasterexpressjs/body-parser:masterfrom be/upgrade-content-typeexpressjs/body-parser:be/upgrade-content-typeCopy head branch name to clipboard
Conversation
Phillip9587
left a comment
There was a problem hiding this comment.
LGTM! But we need to also update it in type-is and express to not duplicate the module in the dependency tree: https://npmgraph.js.org/?q=express#select=content-type%401.0.5
|
😓 Oh damn I missed it was used in this package, since it's still support node 0.6 and has a hard API to work with I guess it's a good candidate to start refactoring. If/when I release the new |
|
I think it does not matter and it is up to you if you but it in a separate PR. I would prefer a single PR for body-parser and one for express. |
|
@Phillip9587 Released |
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
Phillip9587
left a comment
There was a problem hiding this comment.
LGTM. Thanks for all the work @blakeembrey
The parser in
content-type@2is 3x faster and doesn't throw anymore.