deps: qs@^6.14.1 - #689
#689deps: qs@^6.14.1#689UlisesGascon merged 2 commits intomasterexpressjs/body-parser:masterfrom ulises/upgrade-qs-in-2.xexpressjs/body-parser:ulises/upgrade-qs-in-2.xCopy head branch name to clipboard
Conversation
to preserve backcompat in the simpler parse after ljharb/qs@3086902 we need to provide an arrayLimit other than zero input length is already capped by default, enforced by throwing a 413: ```js // throws 413 before parsing when violated options?.parameterLimit = 1000 ``` so the default behavior is that we will parse arrays in simple mode up to parameterLimit. Using `paramCount` because it will always be paramLimit or lower here, and we use it in the other side of the ternary to mean the same thing
|
I pushed the fix to keep backcompat with what we did in the simple mode before
|
| } | ||
|
|
||
| var arrayLimit = extended ? Math.max(100, paramCount) : 0 | ||
| var arrayLimit = extended ? Math.max(100, paramCount) : paramCount |
There was a problem hiding this comment.
the Math.max is here for extended mode to allow sparse arrays, so far as I can tell
UlisesGascon
left a comment
There was a problem hiding this comment.
You are amazing @jonchurch! 👏👏👏
I was going into a much more complex debug locally 😅
|
I included the changes in the |
Related to #687