Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add Worksheet.state typescript definition fix #714 - #736

#736
Merged
Siemienik merged 4 commits into
exceljs:masterexceljs/exceljs:masterfrom
ilyes-kechidi:add-ws-state-typedefilyes-kechidi/exceljs:add-ws-state-typedefCopy head branch name to clipboard
Feb 19, 2019
Merged

add Worksheet.state typescript definition fix #714#736
Siemienik merged 4 commits into
exceljs:masterexceljs/exceljs:masterfrom
ilyes-kechidi:add-ws-state-typedefilyes-kechidi/exceljs:add-ws-state-typedefCopy head branch name to clipboard

Conversation

@ilyes-kechidi

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread index.d.ts Outdated
@alubbe

alubbe commented Feb 11, 2019

Copy link
Copy Markdown
Member

I checked that the default value of the work sheet state is show, but from my understanding the same holds true for the options object when adding worksheets since it's just passed down to the constructor (in this PR, it's default value is visible). In that case, we should define this enum once and the re-use it in both type definitions. what do you think @Siemienik @guyonroche ?

@Siemienik

Copy link
Copy Markdown
Member

@alubbe fully agree,

as far as i know, 'show' is invalid value, it should be 'visible'
#621

@Siemienik
Siemienik self-requested a review February 19, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.