fix: the application decodes and fetches a url from ... in App.tsx#11418
Open
orbisai0security wants to merge 2 commits into
excalidraw:masterexcalidraw/excalidraw:masterfrom
orbisai0security:fix-v-001-url-validation-external-sceneorbisai0security/excalidraw:fix-v-001-url-validation-external-sceneCopy head branch name to clipboard
Open
fix: the application decodes and fetches a url from ... in App.tsx#11418orbisai0security wants to merge 2 commits intoexcalidraw:masterexcalidraw/excalidraw:masterfrom orbisai0security:fix-v-001-url-validation-external-sceneorbisai0security/excalidraw:fix-v-001-url-validation-external-sceneCopy head branch name to clipboard
orbisai0security wants to merge 2 commits into
excalidraw:masterexcalidraw/excalidraw:masterfrom
orbisai0security:fix-v-001-url-validation-external-sceneorbisai0security/excalidraw:fix-v-001-url-validation-external-sceneCopy head branch name to clipboard
Conversation
Automated security fix generated by OrbisAI Security
The application decodes and fetches a URL from user-controlled input (shared links) without any validation or domain allowlisting
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
excalidraw-app/App.tsx.Vulnerability
V-001excalidraw-app/App.tsx:308Description: The application decodes and fetches a URL from user-controlled input (shared links) without any validation or domain allowlisting. While this executes in the browser context rather than server-side, it enables attackers to craft legitimate-looking Excalidraw URLs that redirect victims to malicious content, access local network resources from the victim's browser, or load attacker-controlled data into the application.
Evidence
Exploitation scenario: An attacker crafts a shared link like https://excalidraw.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
excalidraw-app/App.tsxVerification
Security Invariant
Regression test
This test guards against regressions — it's useful independent of the code change above.
Automated security fix by OrbisAI Security