Allow override for Nominatim base URL (v4)#418
Open
bplubell wants to merge 1 commit into
ethercreative:v4ethercreative/simplemap:v4from
bplubell:v4-nominatim-base-urlbplubell/simplemap:v4-nominatim-base-urlCopy head branch name to clipboard
Open
Allow override for Nominatim base URL (v4)#418bplubell wants to merge 1 commit intoethercreative:v4ethercreative/simplemap:v4from bplubell:v4-nominatim-base-urlbplubell/simplemap:v4-nominatim-base-urlCopy head branch name to clipboard
bplubell wants to merge 1 commit into
ethercreative:v4ethercreative/simplemap:v4from
bplubell:v4-nominatim-base-urlbplubell/simplemap:v4-nominatim-base-urlCopy head branch name to clipboard
Conversation
Nominatim can be self-hosted or one might want to use a proxy, for example to implement rate limiting. To support such use cases, I made the Nominatim base URL a setting. The default value is the same origin as was hard-coded in the GeoService requests, so this feature is backwards compatible. Notably, being able to use a rate-limiting proxy helps users ensure they adhere to [Nominatim's usage policy][1]. [1]: https://operations.osmfoundation.org/policies/nominatim/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nominatim can be self-hosted or one might want to use a proxy, for example to implement rate limiting. To support such use cases, I made the Nominatim base URL a setting. The default value is the same origin as was hard-coded in the GeoService requests, so this feature is backwards compatible.
Notably, being able to use a rate-limiting proxy helps users ensure they adhere to Nominatim's usage policy.