flowctl: normalize --prefix trailing slash - #3035
#3035Open
telcharr wants to merge 1 commit into
estuary:masterestuary/flow:masterfrom
telcharr:fix/prefix-trailing-slashtelcharr/flow:fix/prefix-trailing-slashCopy head branch name to clipboard
Open
flowctl: normalize --prefix trailing slash#3035telcharr wants to merge 1 commit intoestuary:masterestuary/flow:masterfrom telcharr:fix/prefix-trailing-slashtelcharr/flow:fix/prefix-trailing-slashCopy head branch name to clipboard
telcharr wants to merge 1 commit into
estuary:masterestuary/flow:masterfrom
telcharr:fix/prefix-trailing-slashtelcharr/flow:fix/prefix-trailing-slashCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
flowctlnow normalizes a user-supplied--prefixto end with/, whichmodels::Prefixrequires. Previously, passing a prefix without a trailing slash was sent to the API verbatim and rejected as an unauthorized name, causing a misleadingPermissionDeniederror even when the user had full access. Applies acrosscatalog list/pull-specs/delete,raw gazctl-env, andalerts subscriptions.Workflow steps:
flowctl catalog pull-specs --prefix AcmeConow behaves the same as--prefix AcmeCo/. The trailing slash is added automatically with a stderr warning noting the change. Prefixes that already end in/are unchanged, so existing usage is unaffected.Documentation links affected:
None. The CLI
--prefixhelp text already describes prefix semantics, the behavior is just more forgiving now. No difference in contract.Notes for reviewers:
Closes #2834. Closes #2608