Add trigger onstartup#343
Conversation
|
@bconn98 can you please review, this seem like a great feature to add , also @Dirreke I think you'll need to rebase to get that check to pass |
|
@estk Yup will do, I was waiting on the checks. Hadn't looked close enough to realize it was just the 1.67 issue |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 63.39% 63.56% +0.17%
==========================================
Files 24 25 +1
Lines 1557 1570 +13
==========================================
+ Hits 987 998 +11
- Misses 570 572 +2 ☔ View full report in Codecov by Sentry. |
|
It can also close #250 . |
gauntl3t12
left a comment
There was a problem hiding this comment.
Still need to review the trigger, rest looks good
|
@Dirreke thanks for your continued work hard work on this. One last comment, but looking excellent otherwise! |
|
Thanks. I don't have envs at the moment. I think I will do it after 02/16. |
|
Bump MSRV to 1.70 for toml |
|
Only concern I have here is bumping MSRV, the goal is to support at least a year old compiler. Any way we can avoid that? |
|
Toml started bumping like crazy. I locked it in my branches at the current, but we can lock it at the previous and maintain 1.69.
|
|
I will rebase it after #354 |
|
Feel free to rebase now @Dirreke |
Add trigger onstartup, ref: log4j