feat: introduce validation levels for lua - #6355
#6355feat: introduce validation levels for lua#6355arkodg merged 1 commit intoenvoyproxy:mainenvoyproxy/gateway:mainfrom rudrakhp:disable_lua_enumCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6355 +/- ##
==========================================
+ Coverage 70.74% 70.76% +0.01%
==========================================
Files 220 220
Lines 37594 37595 +1
==========================================
+ Hits 26596 26604 +8
+ Misses 9431 9426 -5
+ Partials 1567 1565 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
There was a problem hiding this comment.
any other options instead of Runtime ?
There was a problem hiding this comment.
Runtime,Compile&DisabledRun,Load&Disabled--> prefer this since it aligns with underlying gopher-lua terminology. Documentation will have necessary explanation for users.Strict,Syntax&Disabled--> more intuitive for users
|
/retest |
There was a problem hiding this comment.
should we remove this for now and explain this as the default ?
There was a problem hiding this comment.
Removed default kubebuilder on field and added a comment instead.
There was a problem hiding this comment.
can we add a line in here mentioning when its needed, e.g. when importing libraries
There was a problem hiding this comment.
Added. Will update once we have the Syntax enum implemented.
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
| } | ||
|
|
||
| // +kubebuilder:validation:Enum=Strict;Disabled | ||
| type LuaValidation string |
There was a problem hiding this comment.
nit: would it make sense to name it LuaValidationLevel?
|
LGTM, just left one question :) |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
What type of PR is this?
feat: introduce validation levels for lua
What this PR does / why we need it:
Introduce validation levels so users can disable or have runtime validations on their lua script. Will introduce a compile time validation in a follow up PR.
Which issue(s) this PR fixes:
Related discussion in Slack thread
Related: #6172 #6176
Release Notes: Yes