Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Tweak condition for TEXTDECODER=2 default #24349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Tweak condition for TEXTDECODER=2 default #24349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 test/other/codesize/test_codesize_minimal_pthreads.gzsize
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3988
3795
2 changes: 1 addition & 1 deletion 2 test/other/codesize/test_codesize_minimal_pthreads.jssize
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8264
7883
7 changes: 4 additions & 3 deletions 7 tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,11 +1008,12 @@ def limit_incoming_module_api():

# Default to TEXTDECODER=2 (always use TextDecoder to decode UTF-8 strings)
# in -Oz builds, since custom decoder for UTF-8 takes up space.
# In pthreads enabled builds, TEXTDECODER==2 may not work, see
# https://github.com/whatwg/encoding/issues/172
# When supporting shell environments, do not do this as TextDecoder is not
# widely supported there.
if settings.SHRINK_LEVEL >= 2 and not settings.SHARED_MEMORY and \
# In Audio Worklets TextDecoder API is intentionally not exposed
# (https://github.com/WebAudio/web-audio-api/issues/2499) so we also need to
# keep the JavaScript-based fallback.
if settings.SHRINK_LEVEL >= 2 and not settings.AUDIO_WORKLET and \
not settings.ENVIRONMENT_MAY_BE_SHELL:
default_setting('TEXTDECODER', 2)

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.