Tweak condition for TEXTDECODER=2 default #24349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using pthreads, our TextDecoder usage already correctly handles shared memory, so the check and the comment are outdated. - When targeting Audio Worklets, we already have assertion that TEXTDECODER!=2 as it's not compatible with that environment, so opt-out from the size optimisation there instead.
|
Is see the pthreads build uses |
sbc100
approved these changes
May 16, 2025
You mean in the PR description or in a comment in the code? |
The PR description |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextDecoderusage already correctly handles shared memory through thegetUnsharedTextDecoderViewhelper, so the check and the comment are outdated.