Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Access Token Authentication Support#7

Merged
eberquist merged 5 commits into
masteremailable/emailable-python:masterfrom
add-access-token-authenticationemailable/emailable-python:add-access-token-authenticationCopy head branch name to clipboard
Jun 2, 2025
Merged

Add Access Token Authentication Support#7
eberquist merged 5 commits into
masteremailable/emailable-python:masterfrom
add-access-token-authenticationemailable/emailable-python:add-access-token-authenticationCopy head branch name to clipboard

Conversation

@eberquist

@eberquist eberquist commented May 30, 2025

Copy link
Copy Markdown
Contributor

Allows the user to pass in api_key or access_token at the time of request instead of setting a global API key for the client.

@eberquist eberquist requested a review from jclusso May 30, 2025 18:49
jclusso
jclusso reviewed May 30, 2025
View reviewed changes
Comment thread README.md
@eberquist eberquist requested a review from jclusso May 30, 2025 19:07
@eberquist

eberquist commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

Looks like python 3.7 isnt supported on the latest ubuntu version. Guess we either set it to an older version 22.04 or remove 3.7 test

jclusso
jclusso reviewed May 30, 2025
View reviewed changes
Comment thread emailable/client.py Outdated
@jclusso

jclusso commented May 30, 2025

Copy link
Copy Markdown
Member

Looks like python 3.7 isnt supported on the latest ubuntu version. Guess we either set it to an older version 22.04 or remove 3.7 test

I guess we can drop 3.7. It was EOL in 2023. I mean it still probably works. Probably should add 3.13 in since that's the latest.

@danarnold

danarnold commented May 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Looks like python 3.7 isnt supported on the latest ubuntu version. Guess we either set it to an older version 22.04 or remove 3.7 test

I guess we can drop 3.7. It was EOL in 2023. I mean it still probably works. Probably should add 3.13 in since that's the latest.

I agree, I don't think we need to support anything that's currently EOL, and we should include anything that's current. https://devguide.python.org/versions/

@eberquist eberquist requested a review from jclusso June 2, 2025 14:05
jclusso
jclusso reviewed Jun 2, 2025
View reviewed changes
Comment thread tests/test_client.py
@eberquist eberquist merged commit 762325e into master Jun 2, 2025
5 checks passed
@eberquist eberquist deleted the add-access-token-authentication branch June 2, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danarnold danarnold danarnold left review comments

@jclusso jclusso jclusso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eberquist @jclusso @danarnold
Morty Proxy This is a proxified and sanitized view of the page, visit original site.