fix: clarify rule risk headline for webhook actions#2905
Open
alexcf wants to merge 1 commit into
elie222:mainelie222/inbox-zero:mainfrom
alexcf:fix/rule-risk-headline-copyalexcf/inbox-zero:fix/rule-risk-headline-copyCopy head branch name to clipboard
Open
fix: clarify rule risk headline for webhook actions#2905alexcf wants to merge 1 commit intoelie222:mainelie222/inbox-zero:mainfrom alexcf:fix/rule-risk-headline-copyalexcf/inbox-zero:fix/rule-risk-headline-copyCopy head branch name to clipboard
alexcf wants to merge 1 commit into
elie222:mainelie222/inbox-zero:mainfrom
alexcf:fix/rule-risk-headline-copyalexcf/inbox-zero:fix/rule-risk-headline-copyCopy head branch name to clipboard
Conversation
The "Review before enabling" alert always showed "This rule can send
email automatically", but a rule whose only outbound action is
CALL_WEBHOOK does not send email — it POSTs email data to an external
URL (as the detail line below already states). Reword the generic
headline to cover both cases ("send email or share email data") so it
is accurate whether the rule replies/sends or calls a webhook.
Copy-only change; no behaviour change.
|
Someone is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
|
Alex Cruz Farmer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
alexcf
force-pushed
the
fix/rule-risk-headline-copy
branch
from
July 3, 2026 06:41
d90364d to
355e7dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Review before enabling" alert (
PendingCreateRuleCardContentinapps/web/components/assistant-chat/tools.tsx) always renders the headline:For a rule whose only risky action is
CALL_WEBHOOK, this is inaccurate — the rule does not send an email, it POSTs email data to an external URL. The detail line right below it already says this correctly:So the headline over-claims for webhook-only rules.
Fix
The component only receives
riskMessages: string[](not the action types), so rather than thread new props through just for copy, this rewords the shared headline to be accurate for both categories:Covers reply/send/forward ("send email") and
CALL_WEBHOOK("share email data") without a conditional.Copy-only change; no behaviour change.