Protect string comparisons against segfaults - #547
#547Open
JSydll wants to merge 2 commits into
electronicarts:masterelectronicarts/EASTL:masterfrom
JSydll:protect_string_comparisons_against_segfaultsJSydll/EASTL-contrib:protect_string_comparisons_against_segfaultsCopy head branch name to clipboard
Open
Protect string comparisons against segfaults#547JSydll wants to merge 2 commits intoelectronicarts:masterelectronicarts/EASTL:masterfrom JSydll:protect_string_comparisons_against_segfaultsJSydll/EASTL-contrib:protect_string_comparisons_against_segfaultsCopy head branch name to clipboard
JSydll wants to merge 2 commits into
electronicarts:masterelectronicarts/EASTL:masterfrom
JSydll:protect_string_comparisons_against_segfaultsJSydll/EASTL-contrib:protect_string_comparisons_against_segfaultsCopy head branch name to clipboard
Conversation
Contributor
|
Im pretty sure that's intentionaly for perfomance sake |
Author
|
I do acknowledge that Do you have an indication on performance impact in this use case? And maybe a recommendation on an alternative solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intends to resolve #546.
Comparing string objects to
nullptris not prevented by the implementation. Therefore, it should check before starting the actual comparison - which currently leads to a segfault due to the unprotected use ofCharStrlen. Given thatCharStrlenfulfills the standard specification of showing UB when called like that, the issue should be fixed on the calling site.The first commit introduces minimal test cases for the global equality operators for
basic_string, the second the (quite small) fix.