Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: fix timing issue in utilityProcess test fixtures #45964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

test: fix timing issue in utilityProcess test fixtures #45964

merged 2 commits into from
Mar 11, 2025

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Mar 10, 2025 •
edited
Loading

Description of Change

Followup to #45690. The same race condition described there also exists in the esm.js and dns-result-order.js fixtures. This PR ensures that stdout's buffers are flushed before calling process.exit().

This race condition's worth fixing in electron/electron; but FWIW, I'm only seeing this test fail on a downstream build's CI boxes, not in electron/electron's GitHub Actions.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added semver/patch backwards-compatible bug fixes target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Mar 10, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 10, 2025
@codebytere codebytere changed the title fix: timing issue in utilityProcess test fixtures test: fix timing issue in utilityProcess test fixtures Mar 11, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 11, 2025
@codebytere codebytere merged commit 22262c1 into main Mar 11, 2025
74 checks passed
@release-clerk
Copy link

release-clerk bot commented Mar 11, 2025

No Release Notes

@codebytere codebytere deleted the fix/timing-issue-in-utility-process-spec branch March 11, 2025 16:41
This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 11, 2025

I have automatically backported this PR to "35-x-y", please check out #45975

@trop trop bot added in-flight/35-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Mar 11, 2025
@trop
Copy link
Contributor

trop bot commented Mar 11, 2025

I have automatically backported this PR to "34-x-y", please check out #45976

@trop
Copy link
Contributor

trop bot commented Mar 11, 2025

I have automatically backported this PR to "33-x-y", please check out #45977

@trop
Copy link
Contributor

trop bot commented Mar 11, 2025

I have automatically backported this PR to "36-x-y", please check out #45978

@trop trop bot added in-flight/34-x-y in-flight/33-x-y in-flight/36-x-y and removed target/34-x-y PR should also be added to the "34-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Mar 11, 2025
@trop trop bot added merged/36-x-y PR was merged to the "36-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. and removed in-flight/36-x-y in-flight/34-x-y in-flight/35-x-y in-flight/33-x-y labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ckerr @codebytere
Morty Proxy This is a proxified and sanitized view of the page, visit original site.