fix: possible timing issue in utility-process spec #45690
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixture has been calling process.exit() immediately after writing
to stdout and stderr, which the Node.js docs say is risky behavior:
> Calling process.exit() will force the process to exit as quickly as
> possible even if there are still asynchronous operations pending that
> have not yet completed fully, including I/O operations to
> process.stdout and process.stderr.
This fixture's been around for years without problems (AFAIK).
The writes are very small ('hello\n' and 'world') and finish quickly.
But recently I've been testing on a very slow CI machine. There, I see
this spec flaking when it expects stderr to be 'world' but it gets ''.
This PR changes the fixture to wait for stdout & stderr to flush
before calling process.exit().
dsanders11
approved these changes
Feb 19, 2025
With that invitation, seems more like a |
|
No Release Notes |
This was referenced Feb 20, 2025
|
I have automatically backported this PR to "32-x-y", please check out #45726 |
|
I have automatically backported this PR to "35-x-y", please check out #45727 |
|
I have automatically backported this PR to "34-x-y", please check out #45728 |
|
I have automatically backported this PR to "33-x-y", please check out #45729 |
|
This might have something to do with it working on so many machines: #44174 |
4 tasks
3 tasks
|
Follow up issue because this will happen in real apps, too: #47228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixture has been calling process.exit() immediately after writing to stdout and stderr, which the Node.js docs say is risky behavior:
This fixture's been around for years without problems (AFAIK). The writes are very small (
'hello\n'and'world') so they finish quickly. But recently I've been testing on a very slow CI machine. There, I see this spec flaking when it expects stderr to be'world'but it gets''. This PR changes the fixture to wait for stdout & stderr to flush before calling process.exit().I've read through the specs that touch
log.jsand AFAICT this fix doesn't change the semantics of any of spec, e.g. none of them are looking for an unfinished write().Yes, I'm changing a three-line .js file. Bikesheds welcome. 😸
Checklist
npm testpassesRelease Notes
Notes: none