docs: correct breaking changes versions #45173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaurencin
approved these changes
Jan 10, 2025
jkleinsc
approved these changes
Jan 10, 2025
VerteDinde
approved these changes
Jan 11, 2025
|
Release Notes Persisted
|
|
I was unable to backport this PR to "34-x-y" cleanly; |
VerteDinde
added a commit
that referenced
this pull request
Jan 13, 2025
|
@VerteDinde has manually backported this PR to "34-x-y", please check out #45189 |
VerteDinde
added a commit
that referenced
this pull request
Jan 13, 2025
docs: correct breaking changes versions (#45173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the breaking changes doc in preparation for the release of Electron 34. We identified two changes as being in the wrong sections. In both cases the PR merged after the last release, but was opened before it. Thus, their changes to this doc for the "next" version were no longer current.
I added a "correction" note to the section that we sent out in 33 but actually lands in this upcoming 34 release.
Ref: #43402, #43617
Notes: Corrected the release version of the "menu bar will be hidden during fullscreen on Windows" breaking change.