feat: expose frame & move properties to console-message event object #43617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
requested changes
Sep 9, 2024
e49a964 to
ce22499
Compare
|
erickzhao
reviewed
Sep 12, 2024
refactor: use property names similar to ServiceWorker's console-message event refactor: don't use deprecated params in tests doc: console-message breaking change chore: add deprecation warning docs: restore deprecated argument descriptions
04e2b83 to
07f7f6f
Compare
jkleinsc
approved these changes
Sep 26, 2024
jkleinsc
approved these changes
Sep 26, 2024
fbca88b to
9be909b
Compare
|
Release Notes Persisted
|
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…lectron#43617) * feat: expose frame on console-message event refactor: use property names similar to ServiceWorker's console-message event refactor: don't use deprecated params in tests doc: console-message breaking change chore: add deprecation warning docs: restore deprecated argument descriptions * move console-message deprecations to v34 --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…lectron#43617) * feat: expose frame on console-message event refactor: use property names similar to ServiceWorker's console-message event refactor: don't use deprecated params in tests doc: console-message breaking change chore: add deprecation warning docs: restore deprecated argument descriptions * move console-message deprecations to v34 --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…lectron#43617) * feat: expose frame on console-message event refactor: use property names similar to ServiceWorker's console-message event refactor: don't use deprecated params in tests doc: console-message breaking change chore: add deprecation warning docs: restore deprecated argument descriptions * move console-message deprecations to v34 --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
resolves #35418
Implements what @MarshallOfSound proposed in #35418—this time moving properties to the event object.
The stack trace seemed nuanced so I opted not to expose it.
Checklist
npm testpassesRelease Notes
Notes:
frameto 'console-message' event.