Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: do not spawn additional stores inside variant#98

Merged
AlexandrHoroshih merged 4 commits into
mastereffector/reflect:masterfrom
refactor-varianteffector/reflect:refactor-variantCopy head branch name to clipboard
Sep 8, 2025
Merged

fix: do not spawn additional stores inside variant#98
AlexandrHoroshih merged 4 commits into
mastereffector/reflect:masterfrom
refactor-varianteffector/reflect:refactor-variantCopy head branch name to clipboard

Conversation

@AlexandrHoroshih

@AlexandrHoroshih AlexandrHoroshih commented Sep 8, 2025

Copy link
Copy Markdown
Member

variant is spawning a .map store in simplified overload - it is messing with the effector's babel/swc code for Hot Module Reload

To avoid special handling for HMR with reflect we are refactoring this .map store to a mapping inside a react-component

No changes for runtime behavior otherwise

@AlexandrHoroshih
AlexandrHoroshih merged commit 0f789d1 into master Sep 8, 2025
1 check passed
@AlexandrHoroshih
AlexandrHoroshih deleted the refactor-variant branch September 8, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.