Do not require quotes for implicit keys with flow indicators - #494
#494Merged
eemeli merged 1 commit intoAug 28, 2023
maineemeli/yaml:mainfrom
fix-implicit-plain-key-stringeemeli/yaml:fix-implicit-plain-key-stringCopy head branch name to clipboard
Merged
Do not require quotes for implicit keys with flow indicators#494eemeli merged 1 commit intomaineemeli/yaml:mainfrom fix-implicit-plain-key-stringeemeli/yaml:fix-implicit-plain-key-stringCopy head branch name to clipboard
eemeli merged 1 commit into
maineemeli/yaml:mainfrom
fix-implicit-plain-key-stringeemeli/yaml:fix-implicit-plain-key-stringCopy head branch name to clipboard
Conversation
|
Thank you! |
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #493
The oddity here turned out to be in part caused by a mismatch in the YAML spec text & rules; I've filed yaml/yaml-spec#313 to add an errata for that. See there for more technical details, but the fix required here is removing one part of the check in the stringifier. I'd followed the YAML rules for the parser, but the YAML text for the stringifier, and the latter was wrong.