Sourcery refactored main branch#1
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Sourcery refactored main branch#1sourcery-ai[bot] wants to merge 1 commit into
sourcery-ai[bot] wants to merge 1 commit into
Conversation
| # General information about the project. | ||
| project = u'virtualenvwrapper' | ||
| copyright = u'2009-%s, Doug Hellmann' % datetime.datetime.today().year | ||
| copyright = f'2009-{datetime.datetime.now().year}, Doug Hellmann' |
Author
There was a problem hiding this comment.
Lines 48-48 refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Replace datetime.datetime.today() with datetime.datetime.now() (
use-datetime-now-not-today)
| project, project_dir = args | ||
| filename = os.path.join(project_dir, 'TEST_FILE') | ||
| print('Writing to %s' % filename) | ||
| print(f'Writing to {filename}') |
Author
There was a problem hiding this comment.
Function template refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
| # Set up logging to a file | ||
| logfile = os.environ.get('VIRTUALENVWRAPPER_LOG_FILE') | ||
| if logfile: | ||
| if logfile := os.environ.get('VIRTUALENVWRAPPER_LOG_FILE'): |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
This removes the following comments ( why? ):
# Set up logging to a file
Comment on lines
-166
to
+169
| namespace = 'virtualenvwrapper.%s' % hook | ||
| namespace = f'virtualenvwrapper.{hook}' | ||
| if options.names: | ||
| log.debug('looking for %s hooks %s' % (namespace, options.names)) | ||
| log.debug(f'looking for {namespace} hooks {options.names}') | ||
| hook_mgr = NamedExtensionManager(namespace, options.names) | ||
| else: | ||
| log.debug('looking for %s hooks' % namespace) | ||
| log.debug(f'looking for {namespace} hooks') |
Author
There was a problem hiding this comment.
Function run_hooks refactored with the following changes:
- Replace interpolated string formatting with f-string [×5] (
replace-interpolation-with-fstring)
Comment on lines
-32
to
+34
| else: | ||
| for path in os.environ['PATH'].split(';'): | ||
| if os.path.exists(os.path.join(path, 'sh.exe')): | ||
| return [get_path(path, 'sh.exe')] | ||
| for path in os.environ['PATH'].split(';'): | ||
| if os.path.exists(os.path.join(path, 'sh.exe')): | ||
| return [get_path(path, 'sh.exe')] |
Author
There was a problem hiding this comment.
Function _get_msys_shell refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!