chore: replace fs-extra with native Node.js fs APIs#594
Open
roli-lpci wants to merge 1 commit into
ds300:masterds300/patch-package:masterfrom
roli-lpci:chore/replace-fs-extra-with-native-fsroli-lpci/patch-package:chore/replace-fs-extra-with-native-fsCopy head branch name to clipboard
Open
chore: replace fs-extra with native Node.js fs APIs#594roli-lpci wants to merge 1 commit intods300:masterds300/patch-package:masterfrom roli-lpci:chore/replace-fs-extra-with-native-fsroli-lpci/patch-package:chore/replace-fs-extra-with-native-fsCopy head branch name to clipboard
roli-lpci wants to merge 1 commit into
ds300:masterds300/patch-package:masterfrom
roli-lpci:chore/replace-fs-extra-with-native-fsroli-lpci/patch-package:chore/replace-fs-extra-with-native-fsCopy head branch name to clipboard
Conversation
Replace fs-extra dependency with native fs module equivalents:
- copySync → inline recursive copy helper with permission preservation
- mkdirpSync/ensureDirSync → mkdirSync({ recursive: true })
- removeSync → rmSync({ recursive: true, force: true })
- moveSync → renameSync
Also removes @types/fs-extra and bumps @types/node to ^14.14.0
to match the engine requirement (Node >= 14).
Addresses ds300#499
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@ds300 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs-extrausage with native Node.jsfsmodule equivalentscopySynchelper with file permission preservation and symlink dereferencing supportfs-extraand@types/fs-extrafrom dependencies, bumps@types/nodeto^14.14.0Changes
Source files:
src/makePatch.ts— AddedcopySynchelper usingcopyFileSync+chmodSyncfor permission preservation; replacedmkdirpSync→mkdirSync({recursive}),removeSync→rmSync({recursive, force})src/patch/apply.ts—moveSync→renameSync,ensureDirSync→mkdirSync({recursive})src/filterFiles.ts—removeSync→rmSync({force})src/applyPatches.ts,src/detectPackageManager.ts,src/getAppRootPath.ts,src/getPackageResolution.ts,src/patch/read.ts— Import swap fromfs-extratofsTest files:
src/patch/read.test.ts— Updated mock fromfs-extratofsproperty-based-tests/executeTestCase.ts— Rewrote mock to spreadjest.requireActual("fs")with selective overridesintegration-tests/runIntegrationTest.ts— Replacedfs-extra+rimrafwith nativefsintegration-tests/newIntegrationTest.ts—mkdirpSync→mkdirSync({recursive})Dependencies:
package.json— Removedfs-extra,@types/fs-extra; bumped@types/nodeto^14.14.0Testing
Addresses #499