Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: use component manager for icons#6499

Open
kenny-not-dead wants to merge 1 commit into
dream-num:devdream-num/univer:devfrom
kenny-not-dead:useComponentManagerForIconkenny-not-dead/univer:useComponentManagerForIconCopy head branch name to clipboard
Open

feat: use component manager for icons#6499
kenny-not-dead wants to merge 1 commit into
dream-num:devdream-num/univer:devfrom
kenny-not-dead:useComponentManagerForIconkenny-not-dead/univer:useComponentManagerForIconCopy head branch name to clipboard

Conversation

@kenny-not-dead
Copy link
Copy Markdown
Contributor

@kenny-not-dead kenny-not-dead commented Jan 21, 2026 •
edited
Loading

close #xxx

I continued to use the component manager for icons, but the design package is mostly untouched now.

I temporarily installed a different type of ribbon type on the demo so you could make sure it works.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 21, 2026 •
edited
Loading

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@kenny-not-dead kenny-not-dead force-pushed the useComponentManagerForIcon branch 2 times, most recently from 009a2ff to a85140e Compare January 21, 2026 17:41
@kenny-not-dead kenny-not-dead force-pushed the useComponentManagerForIcon branch from a85140e to b415a25 Compare January 21, 2026 18:01
@kenny-not-dead
Copy link
Copy Markdown
Contributor Author

kenny-not-dead commented Jan 21, 2026

I returned ribbon type it because the tests for screenshots were failing, and I wanted to exclude the connection with icons. After returning the type to the default, the test passed.

@kenny-not-dead
Copy link
Copy Markdown
Contributor Author

kenny-not-dead commented Mar 3, 2026

@jikkai
hi, could you clarify if this poses any problems? If it is relevant, I can resolve conflicts that arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs

@VicKun4937 VicKun4937 Awaiting requested review from VicKun4937 VicKun4937 is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@wpxp123456 wpxp123456 Awaiting requested review from wpxp123456 wpxp123456 is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir

@weird94 weird94 Awaiting requested review from weird94

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kenny-not-dead
Morty Proxy This is a proxified and sanitized view of the page, visit original site.