Rebuilding all-settings.c on every ./configure run - #265
#265Open
mauritium wants to merge 1 commit into
dovecot:maindovecot/core:mainfrom
mauritium:pr/bugfix-all-settings-regeneratemauritium/dovecot-core:pr/bugfix-all-settings-regenerateCopy head branch name to clipboard
Open
Rebuilding all-settings.c on every ./configure run#265mauritium wants to merge 1 commit intodovecot:maindovecot/core:mainfrom mauritium:pr/bugfix-all-settings-regeneratemauritium/dovecot-core:pr/bugfix-all-settings-regenerateCopy head branch name to clipboard
mauritium wants to merge 1 commit into
dovecot:maindovecot/core:mainfrom
mauritium:pr/bugfix-all-settings-regeneratemauritium/dovecot-core:pr/bugfix-all-settings-regenerateCopy head branch name to clipboard
Conversation
…re were situations where a prebuilt all-settings.c would get stale in relation to the actual configuration, leading to all kinds of obscure failures downstream. This manifests itself, e.g., in relation to building on macOS, where the all-settings.c bundled with the official source release would include imap-hibernate, which is not available on macOS. For this reason, the homebrew project explicitly `rm`s the file prior to building.
Contributor
|
The problem with this change is that we intentionally didn't want to require Perl for building Dovecot from a tarball. Doesn't the BUILD_IMAP_HIBERNATE handling in configure already fix this? Or could be changed somehow further to fix this? Adding some |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Defensively) rebuilding
all-settings.con every./configurerun. There were situations where a prebuiltall-settings.cwould get stale in relation to the actual configuration, leading to all kinds of obscure failures downstream. This manifests itself, e.g., in relation to building on macOS, where theall-settings.cbundled with the official source release would includeimap-hibernate, which is not available on macOS. For this reason, the homebrew project explicitlyrms the file prior to building. This commit gets rid of the need for the ugly downstream workaround (see Homebrew/homebrew-core@8eed350). @cho-m