Merge | SqlDataReader - #3259
#3259Merged
mdaigle merged 3 commits intoApr 10, 2025
dotnet:maindotnet/SqlClient:mainfrom
edwardneal:merge/sqldatareaderedwardneal/SqlClient:merge/sqldatareaderCopy head branch name to clipboard
Merged
Merge | SqlDataReader#3259mdaigle merged 3 commits intodotnet:maindotnet/SqlClient:mainfrom edwardneal:merge/sqldatareaderedwardneal/SqlClient:merge/sqldatareaderCopy head branch name to clipboard
mdaigle merged 3 commits into
dotnet:maindotnet/SqlClient:mainfrom
edwardneal:merge/sqldatareaderedwardneal/SqlClient:merge/sqldatareaderCopy head branch name to clipboard
Conversation
Also handle the TdsParserStateObject.Cancel method.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmedynski
approved these changes
Apr 8, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
- Coverage 72.83% 66.19% -6.64%
==========================================
Files 298 290 -8
Lines 59675 56944 -2731
==========================================
- Hits 43463 37693 -5770
- Misses 16212 19251 +3039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Apr 10, 2025
This was referenced Jul 25, 2025
Open
This was referenced Jun 29, 2026
Closed
Open
This was referenced Jul 6, 2026
This was referenced Jul 13, 2026
Open
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2965.
Contributes to #1261.
This merges SqlDataReader. It might be worth reviewing each commit individually:
Could someone run CI please?