Lock around access to s_dynamicSymbols - #52887
#52887Merged
Merged
Lock around access to s_dynamicSymbols#52887
Conversation
Member
Author
|
@baronfel Alternative fix |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses thread-safety around the dynamic-completions metadata stored in DynamicSymbolExtensions by synchronizing access to the shared s_dynamicSymbols dictionary.
Changes:
- Add a static lock to guard reads/writes to
s_dynamicSymbols. - Consolidate the extension receiver to
Symbol(instead of separateOption/Argumentextension blocks), keepingIsDynamicfunctionality in one place.
baronfel
approved these changes
Feb 6, 2026
Member
|
Thanks, this is more like what I was thinking based on how the other extensibility points solved concurrency. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #52883