Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/10.0.2xx] Keep template_feed/../content/../.gitattributes in archives - #52772

#52772
Merged
marcpopMSFT merged 1 commit into
dotnet:release/10.0.2xxdotnet/sdk:release/10.0.2xxfrom
baronfel:backport-gitattributes-template-fixes-10.0.200baronfel/sdk:backport-gitattributes-template-fixes-10.0.200Copy head branch name to clipboard
Feb 6, 2026
Merged

[release/10.0.2xx] Keep template_feed/../content/../.gitattributes in archives#52772
marcpopMSFT merged 1 commit into
dotnet:release/10.0.2xxdotnet/sdk:release/10.0.2xxfrom
baronfel:backport-gitattributes-template-fixes-10.0.200baronfel/sdk:backport-gitattributes-template-fixes-10.0.200Copy head branch name to clipboard

Conversation

@baronfel

@baronfel baronfel commented Feb 2, 2026

Copy link
Copy Markdown
Member

Manual backport of #52741 to 10.0.2xx

Issue

Some consumers of the VMR source build consume the git archive generated source tarball. Without this change, the source tarball doesn't include the content/../.gitattributes file, which makes dotnet new gitattributes non-functional.

Risk

Low

Testing

Manual verification, and creating plan for future automated validation in dotnet/source-build#5472

Some consumers of the VMR source build consume the `git archive`
generated source tarball. Without this change, the source tarball doesn't
include the content/../.gitattributes file, which makes `dotnet new
gitattributes` non-functional.

Fixes: dotnet#52307
Copilot AI review requested due to automatic review settings February 2, 2026 15:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a manual backport of #52741 to the 10.0.2xx branch that ensures the .gitattributes template file is included in git archive-generated source tarballs, fixing the dotnet new gitattributes command for VMR source build consumers.

Changes:

  • Added -export-ignore attribute to root .gitattributes to override the template's own export-ignore setting

@baronfel baronfel changed the title Keep template_feed/../content/../.gitattributes in archives [release/10.0.2xx] Keep template_feed/../content/../.gitattributes in archives Feb 2, 2026
@baronfel baronfel added Servicing-consider Area-Common templates Covers templates in the repo (classlib, console, common item templates) labels Feb 2, 2026
@marcpopMSFT

Copy link
Copy Markdown
Member

/ba-g no build for gitattribute files

@marcpopMSFT
marcpopMSFT merged commit 8cef68e into dotnet:release/10.0.2xx Feb 6, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Common templates Covers templates in the repo (classlib, console, common item templates) Servicing-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.