CLI --self-contained description is wrong - #51088
#51088CLI --self-contained description is wrong#51088adegeo wants to merge 2 commits into
Conversation
|
@adegeo you'll need to update the xlf files on your fork to bump the translations. After that, you'll probably need to update the CLI snapshot tests. |
nagilson
left a comment
There was a problem hiding this comment.
That's a great call out. By default, I didn't mean the value of the command argument but the value of the SelfContained property itself. SelfContained itself is 'false' by default (with no argument) but providing --self-contained makes it true. I don't think we need this breaking change string at this point.
|
@baronfel I removed the lines from the translation files. I don't know what to do about the other item you said. |
|
Thank you @adegeo for driving the extra effort to fix the files and improve our docs by making a PR. And to @baronfel for adding help context. I don't think we should expect our doc writers to be able to fix the tests on our repo. This should really be an automatable process and it is not a valuable use of human time/energy to fix either the xlf files or the completions snapshots. I've created #51157 to see if the bot can write something to teach itself to do these tasks for us. |
|
@nagilson I assume this isn't for GA so we probably need to backport to 2xx or retarget to 2xx (whichever works). |
|
Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label. |
59a8d75 to
7fa3c26
Compare
There was a problem hiding this comment.
Pull request overview
This PR corrects the --self-contained help text by removing previously-added defaulting details that actually described the --runtime behavior change (not the --self-contained option itself).
Changes:
- Updates
SelfContainedOptionDescriptionin the source resource (CliStrings.resx) to a single-sentence description. - Propagates the updated English source string across multiple localized
.xlffiles by removing the extra sentence from both<source>and<target>.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/dotnet/CliStrings.resx | Updates the canonical English description for --self-contained. |
| src/Cli/dotnet/xlf/CliStrings.zh-Hant.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.zh-Hans.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.tr.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.ru.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.pt-BR.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.pl.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.ko.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.ja.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.it.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.fr.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.es.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.de.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| src/Cli/dotnet/xlf/CliStrings.cs.xlf | Updates localized resource entry for SelfContainedOptionDescription. |
| <data name="SelfContainedOptionDescription" xml:space="preserve"> | ||
| <value>Publish the .NET runtime with your application so the runtime doesn't need to be installed on the target machine. | ||
| The default is 'false.' However, when targeting .NET 7 or lower, the default is 'true' if a runtime identifier is specified.</value> | ||
| <value>Publish the .NET runtime with your application so the runtime doesn't need to be installed on the target machine.</value> | ||
| </data> |
| <target state="translated">Hiermit wird die .NET-Runtime mit Ihrer Anwendung veröffentlicht, sodass die Runtime nicht auf dem Zielcomputer installiert werden muss. | ||
| Der Standardwert lautet FALSE. Wenn sie jedoch auf .NET 7 oder niedriger abzielen, lautet der Standardwert TRUE, wenn ein Laufzeitbezeichner angegeben wird.</target> | ||
| <source>Publish the .NET runtime with your application so the runtime doesn't need to be installed on the target machine.</source> | ||
| <target state="translated">Hiermit wird die .NET-Runtime mit Ihrer Anwendung veröffentlicht, sodass die Runtime nicht auf dem Zielcomputer installiert werden muss.</target> |
|
Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label. |
7fa3c26 to
730076b
Compare
It looks like #32656 updated the
--self-containeddescription incorrectly. The code change that triggered the old PR was actually related to the --runtime parameter no longer enforcing self-contained=true. It had nothing to do with the --self-contained option itself.--self-contained is an option argument type and defaults to true when passed.
@baronfel