Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

simplify CreateTempSubdirectory - #45633

#45633
Merged
nagilson merged 15 commits into
dotnet:maindotnet/sdk:mainfrom
kasperk81:pathutilkasperk81/sdk:pathutilCopy head branch name to clipboard
Mar 26, 2025
Merged

simplify CreateTempSubdirectory#45633
nagilson merged 15 commits into
dotnet:maindotnet/sdk:mainfrom
kasperk81:pathutilkasperk81/sdk:pathutilCopy head branch name to clipboard

Conversation

@kasperk81

@kasperk81 kasperk81 commented Dec 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

InternalAbstractions netstandard support is only needed by Microsoft.NET.TestFramework.csproj. for that CreateTempSubdirectory is using p/invoke for all dependents

making InternalAbstractions multi-framework same as Microsoft.NET.TestFramework.csproj to simplify CreateTempSubdirectory and deleting unused methods

#45631

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 27, 2024
@build-analysis build-analysis Bot mentioned this pull request Dec 27, 2024
Closed
3 tasks
@kasperk81

kasperk81 commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@marcpopMSFT @baronfel can we backport it to 9.0.2xx?

@marcpopMSFT
marcpopMSFT requested a review from nagilson January 8, 2025 23:25
nagilson
nagilson reviewed Jan 9, 2025
View reviewed changes

@nagilson nagilson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on #45631 (comment)

@kasperk81

kasperk81 commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

updated. it guarantees the desired file mode is set on unix without pinvoke

@build-analysis build-analysis Bot mentioned this pull request Jan 9, 2025
Open
@kasperk81 kasperk81 mentioned this pull request Jan 9, 2025
Closed
nagilson
nagilson reviewed Jan 9, 2025
View reviewed changes
Comment thread src/Common/PathUtilities.cs Outdated
nagilson
nagilson reviewed Jan 9, 2025
View reviewed changes
Comment thread src/Common/PathUtilities.cs Outdated
omajid
omajid reviewed Jan 10, 2025
View reviewed changes
Comment thread src/Common/PathUtilities.cs Outdated
tmds
tmds reviewed Jan 10, 2025
View reviewed changes
Comment thread src/Common/PathUtilities.cs Outdated
This was referenced Jan 10, 2025
Open
Open
edvilme
edvilme reviewed Jan 13, 2025
View reviewed changes
Comment thread src/Cli/Microsoft.DotNet.InternalAbstractions/DirectoryPath.cs
@nagilson
nagilson self-requested a review January 14, 2025 18:50
@build-analysis build-analysis Bot mentioned this pull request Mar 19, 2025
Closed
@build-analysis build-analysis Bot mentioned this pull request Mar 19, 2025
Closed
3 tasks
nagilson
nagilson reviewed Mar 19, 2025
View reviewed changes
Comment thread src/Common/PathUtilities.cs
@nagilson

nagilson commented Mar 20, 2025

Copy link
Copy Markdown
Member

Thank you for this fix and your patience in the review process 👏

@nagilson

nagilson commented Mar 20, 2025

Copy link
Copy Markdown
Member

Failed Microsoft.DotNet.Tests.JoinVerticalsTests.JoinVerticalsCheckAllAmbiguitiesTest [51 ms] Error Message: Assert.DoesNotContain() Failure: Filter matched in collection

System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25169.1

@dotnet/source-build May you PTAL at these failures?

@ellahathaway

ellahathaway commented Mar 20, 2025

Copy link
Copy Markdown
Member

Failed Microsoft.DotNet.Tests.JoinVerticalsTests.JoinVerticalsCheckAllAmbiguitiesTest [51 ms] Error Message: Assert.DoesNotContain() Failure: Filter matched in collection

System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25169.1

@dotnet/source-build May you PTAL at these failures?

See dotnet/source-build#4952

@kasperk81

kasperk81 commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

thanks for syncing with main @nagilson

@nagilson
nagilson merged commit b01c655 into dotnet:main Mar 26, 2025
@kasperk81

kasperk81 commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

@nagilson #45633 related pr replacing direct libc calls leftover from old days. ptal

@kasperk81
kasperk81 deleted the pathutil branch March 27, 2025 07:50
@nagilson

nagilson commented Mar 27, 2025

Copy link
Copy Markdown
Member

@kasperk81 I believe that PR links to this one, your activity is private, and I didnt see any other SDK PRS from you, which one did you mean?

@kasperk81

kasperk81 commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

oh sorry i meant #45637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson approved these changes
+4 more reviewers
@omajid omajid omajid left review comments
@tmds tmds tmds left review comments
@edvilme edvilme edvilme left review comments
@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kasperk81 @nagilson @ellahathaway @omajid @tmds @edvilme @KalleOlaviNiemitalo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.