Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Include LA64 in supported ILCompiler RIDs - #42657

#42657
Merged
baronfel merged 2 commits into
dotnet:maindotnet/sdk:mainfrom
am11:patch-2am11/sdk:patch-2Copy head branch name to clipboard
Aug 13, 2024
Merged

Include LA64 in supported ILCompiler RIDs#42657
baronfel merged 2 commits into
dotnet:maindotnet/sdk:mainfrom
am11:patch-2am11/sdk:patch-2Copy head branch name to clipboard

Conversation

@am11

@am11 am11 commented Aug 10, 2024

Copy link
Copy Markdown
Member

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Aug 10, 2024
@am11

am11 commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

cc @akoeplinger

@marcpopMSFT

Copy link
Copy Markdown
Member

Triage: @richlander do we have any documentation on how customers should go about adding these community rids and which ones we'll take?

@am11

am11 commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

There is nothing new here, loongarch is supported since net60 (see the rest of this file). Its ILCompiler support was added recently in net90.

@baronfel

Copy link
Copy Markdown
Member

@am11 we (SDK team) don't have good knowledge of what platform capabilities are incoming or in flight - is there an epic for 'light up loongarch for XYZ functionality' or something that helps us know that this is part of some unified unit of effort? Or is there another team that should be reviewing this?

@richlander

Copy link
Copy Markdown
Member

These are not so much community RIDs as community architectures.

The big push on RIDs in the past was to get us focused on linux, which we did. We have no issue with adding new architectures. They are not coming at near the pace of distros.

I have no concerns with these changes.

@jkotas @agocke @elinor-fung

@baronfel
baronfel merged commit ddbc223 into dotnet:main Aug 13, 2024
@baronfel

Copy link
Copy Markdown
Member

Thanks for the clarity folks - in the future an epic or something would make these kinds of PRs much more routine.

@jkotas

jkotas commented Aug 13, 2024

Copy link
Copy Markdown
Member

I agree with @richlander .

The architecture that requires hardcoding the lists of RIDs in the SDK is a bit of unfortunate. I think it would be better to just depend on a package availability, but that's not a simple fix.

@jkotas

jkotas commented Aug 13, 2024

Copy link
Copy Markdown
Member

in the future an epic or something would make these kinds of PRs much more routine.

This is our documentation for contributing ports: https://github.com/dotnet/runtime/blob/main/CONTRIBUTING.md#contributing-ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.