[mono] CodeQL fix set #1 - #99637
#99637Merged
kg merged 4 commits intoMar 14, 2024
Merged
Conversation
This was referenced Mar 12, 2024
kg
marked this pull request as ready for review
March 13, 2024 20:41
kg
requested review from
BrzVlad,
fanyang-mono,
lambdageek,
steveisok,
thaystg and
vargaz
as code owners
March 13, 2024 20:41
steveisok
approved these changes
Mar 13, 2024
lambdageek
reviewed
Mar 13, 2024
Comment on lines
5852
to
+5854
| icomparable_inst = mono_class_inflate_generic_class_checked (icomparable, &ctx, error); | ||
| mono_error_assert_ok (error); /* FIXME don't swallow the error */ | ||
| g_assert (icomparable_inst); |
Member
There was a problem hiding this comment.
I really wish we could teach CodeQL that for some functions that have a MonoError * argument, that if is_ok (error) then the return value is non-null. Otherwise these kinds of assertions are pretty lame.
lambdageek
reviewed
Mar 13, 2024
lambdageek
reviewed
Mar 13, 2024
lambdageek
approved these changes
Mar 13, 2024
lambdageek
left a comment
Member
There was a problem hiding this comment.
Looks ok, but I wish we could systematically fix these code patterns:
SomeResult *result = callee(arg1, arg, error);
mono_error_assert_ok (error); // we should get to know that result != NULL hereby adding some kind of annotation to callee.
Contributor
Author
Yeah, I'm not sure whether there is no relevant annotation or if the annotations just aren't documented. |
fanyang-mono
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL flagged various places where we're dereferencing pointers that could be NULL, this PR systematically cleans some of them up via g_assert. (Note that CodeQL doesn't currently recognize g_assert as an assertion... working on that)