Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable QueueUserAPC2 suspension even without CET - #99076

#99076
Merged
jkotas merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
jkotas:EnableAPC2jkotas/runtime:EnableAPC2Copy head branch name to clipboard
Feb 28, 2024
Merged

Enable QueueUserAPC2 suspension even without CET#99076
jkotas merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
jkotas:EnableAPC2jkotas/runtime:EnableAPC2Copy head branch name to clipboard

Conversation

@jkotas

@jkotas jkotas commented Feb 28, 2024

Copy link
Copy Markdown
Member

No description provided.

@jkotas
jkotas requested review from VSadov and kouvel February 28, 2024 19:56
@ghost ghost assigned jkotas Feb 28, 2024
@ghost ghost added the area-VM-coreclr label Feb 28, 2024
@jkotas

jkotas commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

I think have QueueUserAPC2-based suspension enable for native AOT unconditionally. We should do the same for regular CoreCLR.

@VSadov

VSadov commented Feb 28, 2024

Copy link
Copy Markdown
Member

I think have QueueUserAPC2-based suspension enable for native AOT unconditionally. We should do the same for regular CoreCLR.

Yes, QueueUserAPC2 scales a lot better than linear one-by-one thread suspension.
The comment had "once had .. enough bake time". I think we had enough of that by now.

@VSadov VSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkotas
jkotas merged commit dac4446 into dotnet:main Feb 28, 2024
@jkotas
jkotas deleted the EnableAPC2 branch February 28, 2024 23:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.