Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[LoongArch64] amend the tests' building on LA64. - #73840

#73840
Merged
akoeplinger merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
shushanhf:LA_tests_configureshushanhf/runtime:LA_tests_configureCopy head branch name to clipboard
Aug 17, 2022
Merged

[LoongArch64] amend the tests' building on LA64.#73840
akoeplinger merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
shushanhf:LA_tests_configureshushanhf/runtime:LA_tests_configureCopy head branch name to clipboard

Conversation

@shushanhf

Copy link
Copy Markdown
Contributor

This PR is part of the issue #69705 to amend the LA's port.

This PR is fixing the tests building configuration on LoongArch64.

@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 12, 2022
@shushanhf

shushanhf commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

Hi, @JulieLeeMSFT
Could you help adding the label and proper reviewer ?
Thanks

@kunalspathak kunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will merge it after we fork for .NET 8.

@teo-tsirpanis teo-tsirpanis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 12, 2022
Comment thread src/tests/Interop/PInvoke/Generics/CMakeLists.txt Outdated
to the `Common/Platform/platformdefines.h`.
@am11 am11 added area-Infrastructure and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 15, 2022
@ghost

ghost commented Aug 15, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

This PR is fixing the tests building configuration on LoongArch64.

Author: shushanhf
Assignees: kunalspathak, shushanhf
Labels:

area-Infrastructure, community-contribution

Milestone: 8.0.0

@am11 am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akoeplinger
akoeplinger merged commit 25e5085 into dotnet:main Aug 17, 2022
@shushanhf
shushanhf deleted the LA_tests_configure branch August 18, 2022 00:51
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.