Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Draft] Fix hard link creation in tar tests in Android, iOS, tvOS#69416

Closed
carlossanlop wants to merge 3 commits into
dotnet:maindotnet/runtime:mainfrom
carlossanlop:Fix68360Copy head branch name to clipboard
Closed

[Draft] Fix hard link creation in tar tests in Android, iOS, tvOS#69416
carlossanlop wants to merge 3 commits into
dotnet:maindotnet/runtime:mainfrom
carlossanlop:Fix68360Copy head branch name to clipboard

Conversation

@carlossanlop

@carlossanlop carlossanlop commented May 17, 2022

Copy link
Copy Markdown
Contributor

Fixes #68360

My suspicion is that in Android, iOS and tvOS (the only Unix platforms where this test failed) need to be elevated so the hardlink can be created.

My suspicion was wrong. We cannot elevate in those platforms.

In Android, it's not possible to create hard links so we should skip in that platform.

In iOS/tvOS we should be able to, but the logic that generated the "sanitized" path was not generating it correctly.

@carlossanlop carlossanlop added this to the 7.0.0 milestone May 17, 2022
@carlossanlop carlossanlop self-assigned this May 17, 2022
@ghost

ghost commented May 17, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68360

My suspicion is that in Android, iOS and tvOS (the only Unix platforms where this test failed) need to be elevated so the hardlink can be created.

Draft since I need to test this hypothesis in the CI first.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO

Milestone: 7.0.0

@carlossanlop

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@carlossanlop
carlossanlop marked this pull request as ready for review May 18, 2022 00:57
@carlossanlop carlossanlop changed the title [Draft] Fix hard link creation in tar tests in Android, iOS, tvOS Fix hard link creation in tar tests in Android, iOS, tvOS May 18, 2022
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
carlossanlop marked this pull request as draft May 18, 2022 19:30
@carlossanlop carlossanlop changed the title Fix hard link creation in tar tests in Android, iOS, tvOS [Draft] Fix hard link creation in tar tests in Android, iOS, tvOS May 18, 2022
…zation, mavoid locaal method to improve stacktrace.
…to potential long paths when extracting to temp dir.
@carlossanlop

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

Copy link
Copy Markdown
Contributor Author

The test was recently disabled in LinuxBionic. I need to see the CI results to determine what to do there.

Comment thread src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs Outdated
@carlossanlop

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

Copy link
Copy Markdown
Contributor Author

The runtime-extra-platforms pipeline was failing instantly after executing it due to some external widespread problem. Running again.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
carlossanlop marked this pull request as ready for review May 28, 2022 03:28
@carlossanlop

Copy link
Copy Markdown
Contributor Author

This PR will end up fixing two bugs. Will resubmit soon.

@carlossanlop
carlossanlop deleted the Fix68360 branch June 16, 2022 17:01
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract_HardLinkEntry_TargetInsideDirectory test from System.Formats.Tar.Tests fails on Android/iOS/tvOS

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.