Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/5.0-preview2] Fix overaggressive CanBeMadeAtomic check for Set + Notone - #33409

#33409
Merged
danmoseley merged 1 commit into
dotnet:release/5.0-preview2dotnet/runtime:release/5.0-preview2from
stephentoub:port33405_2stephentoub/runtime:port33405_2Copy head branch name to clipboard
Mar 10, 2020
Merged

[release/5.0-preview2] Fix overaggressive CanBeMadeAtomic check for Set + Notone#33409
danmoseley merged 1 commit into
dotnet:release/5.0-preview2dotnet/runtime:release/5.0-preview2from
stephentoub:port33405_2stephentoub/runtime:port33405_2Copy head branch name to clipboard

Conversation

@stephentoub

Copy link
Copy Markdown
Member

Port #33405 to release/5.0-preview2

We're erroneously converting a set loop to be atomic when it's followed by a notone where the notone's character is in the set.  But if we for example have `[ab]*[^a]`, we can't make the loop atomic, because the `[ab]*` can actually give back something (a `b`) that the `[^a]` will match.  The fix is simply to delete the erroneous, overaggressive checks.
@danmoseley

Copy link
Copy Markdown
Contributor

approved by tactics

@danmoseley
danmoseley merged commit d12f79a into dotnet:release/5.0-preview2 Mar 10, 2020
@danmoseley

Copy link
Copy Markdown
Contributor

@javiercn it would be great if you would check the first full stack preview 2 build we get and confirm this is fixed.

@stephentoub
stephentoub deleted the port33405_2 branch April 17, 2020 20:02
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.