Fix possible NRE in System.Management.ManagementObject.Get(ManagementOperationObserver watcher) - #131261
#131261Open
sancheolz wants to merge 2 commits into
Open
Fix possible NRE in System.Management.ManagementObject.Get(ManagementOperationObserver watcher)#131261sancheolz wants to merge 2 commits into
sancheolz wants to merge 2 commits into
Conversation
…OperationObserver watcher) in Value sink, which is result of method invocation with possible null return value, is dereferenced in member access expression sink.Stub.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-management |
huoyaoyuan
reviewed
Jul 23, 2026
Comment on lines
+907
to
+908
| if (sink == null) | ||
| throw new InvalidOperationException("Unable to get WmiGetEventSink"); |
Member
There was a problem hiding this comment.
This is not the correct fix. GetNewGetSink can only return null by swallowing an exception. If we want to throw, we should let the orignal exception throw.
Contributor
Author
There was a problem hiding this comment.
Should I remove try/catch from GetNewGetSink then?
Member
There was a problem hiding this comment.
System.Management hasn't enabled nullable analysis, and there are plenty of code quality issues. It's not suggested to address individual warning like this unless the area owner explicitly requires.
This was referenced Jul 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value sink, which is result of method invocation with possible null return value, is dereferenced in member access expression sink.Stub.
It may throw an NRE, as GetNewGetSink may return null at line 919 in ManagementOperationWatcher.cs. https://github.com/sancheolz/runtime/blob/2adc1e07268539ac8be8ad775b2972e91528ebb0/src/libraries/System.Management/src/System/Management/ManagementOperationWatcher.cs#L297
Found by Linux Verification Center (linuxtesting.org) with SVACE.