Add `contentEncoding: base64` to JSON schema for byte[], Memory<byte>, and ReadOnlyMemory<byte> by Copilot · Pull Request #130881 · dotnet/runtime

Copilot · Jul 16, 2026

JsonSchemaExporter was not emitting "contentEncoding": "base64" for byte-array types, despite STJ serializing them as base64 strings. Per JSON Schema 2020-12 §8.3, contentEncoding should be set when the string payload is encoded.

Schema changes:

Added ContentEncoding property and ContentEncodingPropertyName = "contentEncoding" constant to the internal JsonSchema class, following the same pattern as Format, Pattern, etc.
Updated KeywordCount and ToJsonNode to include ContentEncoding

Converter changes — updated GetSchema() to return ContentEncoding = "base64" in:

ByteArrayConverter
MemoryByteConverter
ReadOnlyMemoryByteConverter

Before / After:

// Before
{ "type": ["string", "null"] }

// After — byte[]
{ "type": ["string", "null"], "contentEncoding": "base64" }

// After — Memory<byte> / ReadOnlyMemory<byte>
{ "type": "string", "contentEncoding": "base64" }

azure-pipelines · Jul 16, 2026

Azure Pipelines: 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · Jul 16, 2026

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

…ReadOnlyMemory<byte> Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

eiriktsarpalis

Thanks

azure-pipelines · Jul 16, 2026

Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

This PR updates System.Text.Json’s JSON Schema export so that schemas for byte[], Memory<byte>, and ReadOnlyMemory<byte> explicitly describe their base64 string encoding via the JSON Schema contentEncoding keyword.

Changes:

Added ContentEncoding support to the internal JsonSchema model (KeywordCount + JSON emission).
Updated the byte-oriented converters’ GetSchema() implementations to set ContentEncoding = "base64".
Updated JsonSchemaExporterTests expectations for the affected types.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.TestTypes.cs	Updates expected schemas for `byte[]`, `Memory<byte>`, and `ReadOnlyMemory<byte>` to include `contentEncoding`.
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ReadOnlyMemoryByteConverter.cs	Emits `contentEncoding: "base64"` for `ReadOnlyMemory<byte>` schemas.
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/MemoryByteConverter.cs	Emits `contentEncoding: "base64"` for `Memory<byte>` schemas.
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteArrayConverter.cs	Emits `contentEncoding: "base64"` for `byte[]` schemas.
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs	Adds `ContentEncoding` keyword plumbing and serialization to JSON nodes.

Youssef1313 · Jul 17, 2026

Failure is

D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\TrimmingTests\HybridCacheEntryOptionsAccessorTest.cs(17,6): error CS0246: The type or namespace name 'UnsafeAccessorAttribute' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\Microsoft.Extensions.Caching.Abstractions.Tests.csproj::TargetFramework=net481]
D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\TrimmingTests\HybridCacheEntryOptionsAccessorTest.cs(17,6): error CS0246: The type or namespace name 'UnsafeAccessor' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\Microsoft.Extensions.Caching.Abstractions.Tests.csproj::TargetFramework=net481]
D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\TrimmingTests\HybridCacheEntryOptionsAccessorTest.cs(17,21): error CS0103: The name 'UnsafeAccessorKind' does not exist in the current context [D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Caching.Abstractions\tests\Microsoft.Extensions.Caching.Abstractions.Tests.csproj::TargetFramework=net481]

a fix was merged 5 hours ago in #130892

…coding

github-actions · Jul 19, 2026

Workflow state for the Holistic Review Orchestrator.

{
  "version": 5,
  "last_dispatched_commit": "ebe741af69515dca08f4d05e97e73fc74cd6c2e9",
  "last_dispatched_base_ref": "main",
  "last_dispatched_base_sha": "455968886e6286974cc150d9ab1634c8e7ddf9a0",
  "last_reviewed_commit": "ebe741af69515dca08f4d05e97e73fc74cd6c2e9",
  "last_reviewed_base_ref": "main",
  "last_reviewed_base_sha": "455968886e6286974cc150d9ab1634c8e7ddf9a0",
  "last_recorded_worker_run_id": "29686420391",
  "review_attempt_commit": "",
  "review_attempt_base_ref": "",
  "review_attempt_count": 0,
  "max_review_attempts": 5,
  "review_history_format": "holistic-review-disclosure-v1",
  "review_history": [
    {
      "commit": "ebe741af69515dca08f4d05e97e73fc74cd6c2e9",
      "review_id": 4730732629
    }
  ]
}

github-actions

Holistic Review

Motivation: JsonSchemaExporter serializes byte[], Memory<byte>, and ReadOnlyMemory<byte> as base64-encoded JSON strings, but the emitted schema only declared "type": "string" without indicating the encoding. Per JSON Schema 2020-12 §8.3, contentEncoding should describe how the string payload is encoded, so consumers of the generated schema can validate and interpret the value correctly. The motivation is sound and verifiable from the converters, which all call WriteBase64StringValue.

Approach: The change adds a ContentEncoding string property (with a contentEncoding keyword constant) to the internal JsonSchema class, following the exact pattern already used for Format, Pattern, MinLength, and MaxLength. KeywordCount and ToJsonNode are both updated to include the new keyword, and the three byte-oriented value converters set ContentEncoding = "base64" in their GetSchema overrides. This is the minimal, idiomatic way to extend the internal schema model and is consistent with the surrounding code.

Summary: The implementation is correct and complete. KeywordCount is kept in sync with ToJsonNode (important, since the exporter uses the count to decide between boolean and object schemas), the new property uses the same VerifyMutable mutability guard as its siblings, and the test expectations in JsonSchemaExporterTests.TestTypes.cs are updated to match the new output for all three types. The only externally observable effect is the addition of "contentEncoding": "base64" to these schemas, which is the intended improvement and is well covered by the existing round-trip schema tests. contentMediaType is intentionally omitted, which is reasonable since base64-encoded bytes have no inherent media type. No correctness, performance, or API-surface concerns (the changed JsonSchema type is internal). LGTM.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 37.5 AIC · ⌖ 9.49 AIC · ⊞ 10K

…coding

Youssef1313 · Jul 22, 2026

@eiriktsarpalis Could we consider this for .NET 11 Preview 7 (snapped already yesterday) please?

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

eiriktsarpalis · Jul 22, 2026

Could we consider this for .NET 11 Preview 7 (snapped already yesterday) please?

Sure, if you could take care of the backporting process.

Youssef1313 · Jul 22, 2026

/backport to release/11.0-preview7

github-actions · Jul 22, 2026

Started backporting to release/11.0-preview7 (link to workflow run)

github-actions · Jul 22, 2026

@Youssef1313 backporting to release/11.0-preview7 was not run because the source pull request has not been merged. Please merge this pull request before requesting a backport.

Youssef1313 · Jul 27, 2026

/backport to release/11.0-preview7

github-actions · Jul 27, 2026

Started backporting to release/11.0-preview7 (link to workflow run)

github-actions · Jul 27, 2026

@Youssef1313 backporting to release/11.0-preview7 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Creating an empty commit: Initial plan
Applying: Add contentEncoding: base64 to JSON schema for byte[], Memory<byte>, ReadOnlyMemory<byte>
Using index info to reconstruct a base tree...
M	src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs
M	src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteArrayConverter.cs
M	src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.TestTypes.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs
CONFLICT (content): Merge conflict in src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs
Auto-merging src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteArrayConverter.cs
Auto-merging src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.TestTypes.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Add contentEncoding: base64 to JSON schema for byte[], Memory<byte>, ReadOnlyMemory<byte>
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

…yte[], Memory, and ReadOnlyMemory Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Initial plan

3eb3888

Copilot AI assigned Copilot and Youssef1313 Jul 16, 2026

Copilot AI requested review from Copilot and removed request for Copilot July 16, 2026 15:31

Copilot AI linked an issue Jul 16, 2026 that may be closed by this pull request

JsonSchemaExporter interaction with byte[] #130869

Closed

Copilot started work on behalf of Youssef1313 July 16, 2026 15:32 View session

github-actions Bot added the area-Infrastructure label Jul 16, 2026

github-project-automation Bot added this to Runtime Infra Jul 16, 2026

Add contentEncoding: base64 to JSON schema for byte[], Memory<byte>, …

e400489

…ReadOnlyMemory<byte> Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot July 16, 2026 15:59

Copilot AI changed the title ~~[WIP] Fix JsonSchemaExporter interaction with byte[] for contentEncoding~~ Add contentEncoding: base64 to JSON schema for byte[], Memory<byte>, and ReadOnlyMemory<byte> Jul 16, 2026

Copilot finished work on behalf of Youssef1313 July 16, 2026 16:00

Copilot AI requested a review from Youssef1313 July 16, 2026 16:00

eiriktsarpalis approved these changes Jul 16, 2026

View reviewed changes

Youssef1313 marked this pull request as ready for review July 16, 2026 18:17

Copilot AI review requested due to automatic review settings July 16, 2026 18:17

Copilot AI temporarily deployed to copilot-pat-pool July 16, 2026 18:17 Inactive

Copilot AI temporarily deployed to copilot-pat-pool July 16, 2026 18:18 Inactive

Copilot started reviewing on behalf of Youssef1313 July 16, 2026 18:18 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Jul 17, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

Merge branch 'main' into copilot/fix-jsonschemaexporter-byte-array-en…

ebe741a

…coding

Copilot AI review requested due to automatic review settings July 17, 2026 14:45

Youssef1313 temporarily deployed to copilot-pat-pool July 17, 2026 14:45 — with GitHub Actions Inactive

github-actions Bot reviewed Jul 19, 2026

View reviewed changes

Merge branch 'main' into copilot/fix-jsonschemaexporter-byte-array-en…

97cd2f4

…coding

Copilot AI review requested due to automatic review settings July 22, 2026 14:35

Copilot started reviewing on behalf of Youssef1313 July 22, 2026 14:36 View session

Youssef1313 mentioned this pull request Jul 22, 2026

Built-in OpenAPI generator emits 3.0-era format: binary for binary/file types in 3.1/3.2 documents dotnet/aspnetcore#67826

Open

1 task

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs Outdated

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs Outdated

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs Outdated

Apply suggestions from code review

99b1a95

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 22, 2026 14:42

Copilot started reviewing on behalf of Youssef1313 July 22, 2026 14:43 View session

Copilot AI reviewed Jul 22, 2026

View reviewed changes

This was referenced Jul 22, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

Youssef1313 enabled auto-merge (squash) July 26, 2026 09:28

eiriktsarpalis approved these changes Jul 27, 2026

View reviewed changes

Youssef1313 merged commit f561b0b into main Jul 27, 2026
82 of 85 checks passed

Youssef1313 deleted the copilot/fix-jsonschemaexporter-byte-array-encoding branch July 27, 2026 09:44

github-project-automation Bot moved this to Done in Runtime Infra Jul 27, 2026

Copilot AI added a commit that referenced this pull request Jul 27, 2026

Backport PR #130881: Add contentEncoding: base64 to JSON schema for b…

874217e

…yte[], Memory, and ReadOnlyMemory Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot AI mentioned this pull request Jul 27, 2026

[release/11.0-preview7] Add contentEncoding: base64 to JSON schema for byte[], Memory, and ReadOnlyMemory #131412

Closed

dotnet-maestro Bot mentioned this pull request Jul 28, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#8003

Merged

dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Jul 28, 2026

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

Copilot AI commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Jul 16, 2026

Uh oh!

dotnet-policy-service Bot commented Jul 16, 2026

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Youssef1313 commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Holistic Review

Uh oh!

Youssef1313 commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

eiriktsarpalis commented Jul 22, 2026

Uh oh!

Youssef1313 commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

Uh oh!

Youssef1313 commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 16, 2026 •

edited

Loading

github-actions Bot commented Jul 19, 2026 •

edited

Loading