Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Ignore all 5xx responses in Deflate remote server test - #130775

#130775
Merged
MihaZupan merged 2 commits into
maindotnet/runtime:mainfrom
copilot/httpbin-error-503-fixdotnet/runtime:copilot/httpbin-error-503-fixCopy head branch name to clipboard
Jul 16, 2026
Merged

Ignore all 5xx responses in Deflate remote server test#130775
MihaZupan merged 2 commits into
maindotnet/runtime:mainfrom
copilot/httpbin-error-503-fixdotnet/runtime:copilot/httpbin-error-503-fixCopy head branch name to clipboard

Conversation

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate test hits the external httpbin.org/deflate endpoint, which has been returning frequent 503 Service Temporarily Unavailable responses. The test already tolerated a fixed set of gateway errors (502/504) and 503, but the endpoint can return other transient 5xx codes.

Changes

  • Broadened the tolerated-error check in HttpClientHandlerTest.RemoteServer.cs to skip on any 5xx response instead of the specific BadGateway/GatewayTimeout/ServiceUnavailable set.
using HttpResponseMessage response = await client.GetAsync(uri);
if ((int)response.StatusCode >= 500)
{
    // Ignore any 5xx server error, the test depends on an external server that is out of our control.
    _output.WriteLine(response.ToString());
    return;
}

Copilot AI requested review from Copilot and removed request for Copilot July 15, 2026 12:26
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
15 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI linked an issue Jul 15, 2026 that may be closed by this pull request
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot July 15, 2026 12:30
Copilot AI changed the title [WIP] Fix HTTP Error 503 for httpbin.org/deflate Ignore all 5xx responses in Deflate remote server test Jul 15, 2026
Copilot AI requested a review from MihaZupan July 15, 2026 12:31
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MihaZupan
MihaZupan marked this pull request as ready for review July 15, 2026 12:57
Copilot AI review requested due to automatic review settings July 15, 2026 12:57
Copilot AI temporarily deployed to copilot-pat-pool July 15, 2026 12:57 Inactive
@MihaZupan MihaZupan added this to the 11.0.0 milestone Jul 15, 2026
@MihaZupan
MihaZupan requested a review from a team July 15, 2026 12:58
Copilot AI temporarily deployed to copilot-pat-pool July 15, 2026 12:58 Inactive
@MihaZupan
MihaZupan enabled auto-merge (squash) July 15, 2026 12:58
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a System.Net.Http remote-server test to be more resilient to transient server failures from an external endpoint by relaxing the “tolerate and skip” status-code check.

Changes:

  • Broadened the skip condition in the GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate test from a small set of gateway-related status codes to a general 5xx check.
  • Updated the explanatory comment to reflect the broader skip behavior.

@MihaZupan
MihaZupan merged commit f3f8ded into main Jul 16, 2026
92 checks passed
@MihaZupan
MihaZupan deleted the copilot/httpbin-error-503-fix branch July 16, 2026 00:10
@dotnet-milestone-bot dotnet-milestone-bot Bot modified the milestones: 11.0.0, 11.0-preview7 Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httpbin.org/deflate returns HTTP Error 503

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.