Ignore all 5xx responses in Deflate remote server test - #130775
#130775Merged
MihaZupan merged 2 commits intoJul 16, 2026
maindotnet/runtime:mainfrom
copilot/httpbin-error-503-fixdotnet/runtime:copilot/httpbin-error-503-fixCopy head branch name to clipboard
Merged
Ignore all 5xx responses in Deflate remote server test#130775MihaZupan merged 2 commits intomaindotnet/runtime:mainfrom copilot/httpbin-error-503-fixdotnet/runtime:copilot/httpbin-error-503-fixCopy head branch name to clipboard
MihaZupan merged 2 commits into
maindotnet/runtime:mainfrom
copilot/httpbin-error-503-fixdotnet/runtime:copilot/httpbin-error-503-fixCopy head branch name to clipboard
Conversation
|
Azure Pipelines: 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix HTTP Error 503 for httpbin.org/deflate
Ignore all 5xx responses in Deflate remote server test
Jul 15, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Jul 15, 2026
MihaZupan
marked this pull request as ready for review
July 15, 2026 12:57
MihaZupan
enabled auto-merge (squash)
July 15, 2026 12:58
|
Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a System.Net.Http remote-server test to be more resilient to transient server failures from an external endpoint by relaxing the “tolerate and skip” status-code check.
Changes:
- Broadened the skip condition in the
GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflatetest from a small set of gateway-related status codes to a general 5xx check. - Updated the explanatory comment to reflect the broader skip behavior.
ManickaP
approved these changes
Jul 15, 2026
This was referenced Jul 15, 2026
This was referenced Jul 15, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflatetest hits the externalhttpbin.org/deflateendpoint, which has been returning frequent503 Service Temporarily Unavailableresponses. The test already tolerated a fixed set of gateway errors (502/504) and 503, but the endpoint can return other transient 5xx codes.Changes
HttpClientHandlerTest.RemoteServer.csto skip on any 5xx response instead of the specificBadGateway/GatewayTimeout/ServiceUnavailableset.