Re-enable CborDocument_Roundtrip on iOS/tvOS - #130559
#130559Merged
tannergooding merged 2 commits intoJul 14, 2026
maindotnet/runtime:mainfrom
copilot/fix-biginteger-compareto-crashdotnet/runtime:copilot/fix-biginteger-compareto-crashCopy head branch name to clipboard
Merged
Re-enable CborDocument_Roundtrip on iOS/tvOS#130559tannergooding merged 2 commits intomaindotnet/runtime:mainfrom copilot/fix-biginteger-compareto-crashdotnet/runtime:copilot/fix-biginteger-compareto-crashCopy head branch name to clipboard
tannergooding merged 2 commits into
maindotnet/runtime:mainfrom
copilot/fix-biginteger-compareto-crashdotnet/runtime:copilot/fix-biginteger-compareto-crashCopy head branch name to clipboard
Conversation
Co-authored-by: tannergooding <10487869+tannergooding@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix BigInteger CompareTo crash in CborDocument_Roundtrip test
Re-enable CborDocument_Roundtrip on iOS/tvOS
Jul 11, 2026
tannergooding
marked this pull request as ready for review
July 12, 2026 03:08
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the CborDocument_Roundtrip FsCheck property test on iOS/tvOS by removing the platform-scoped [ActiveIssue] skip, allowing CI to validate whether the historical BigInteger.CompareTo crash still reproduces on those platforms.
Changes:
- Removed
[ActiveIssue("https://github.com/dotnet/runtime/issues/73150", TestPlatforms.iOS | TestPlatforms.tvOS)]fromCborDocument_Roundtrip, so it now runs on iOS/tvOS again.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Formats.Cbor/tests/PropertyTests/CborPropertyTests.cs | Removes the iOS/tvOS ActiveIssue skip from CborDocument_Roundtrip to re-enable the test on those platforms. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Member
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@kotlarmilos there look to be other failures, but none for CborDocument_Roundtrip |
Member
|
Yes, feel free to merge but
I don't think the problem was the test you enabled here. Additionally, it was happening on Mono, so we should check again all disabled test suites. |
kotlarmilos
approved these changes
Jul 14, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the agent instructions on #73150, re-enable the
CborDocument_Roundtripproperty test on iOS/tvOS to see if the originalBigInteger.CompareTocrash still reproduces after the BigInteger internals rewrite and subsequent bug fixes.src/libraries/System.Formats.Cbor/tests/PropertyTests/CborPropertyTests.cs: Remove the[ActiveIssue("https://github.com/dotnet/runtime/issues/73150", TestPlatforms.iOS | TestPlatforms.tvOS)]attribute fromCborDocument_Roundtrip.[Property(Replay = ReplaySeed, MaxTest = MaxTests, Arbitrary = new[] { typeof(CborRandomGenerators) })] -[ActiveIssue("https://github.com/dotnet/runtime/issues/73150", TestPlatforms.iOS | TestPlatforms.tvOS)] public static void CborDocument_Roundtrip(CborPropertyTestContext input)The iOS/tvOS CI legs are the only reliable signal here — the failure was previously reported as not reproducible locally. If CI still crashes in
BigInteger.CompareTo, the attribute should be restored and #73150 reopened for deeper investigation into the underlying numerics issue on Mono/iOS.Note
This PR was authored by GitHub Copilot (AI).