Increase RemoteExecutor timeout for DiagnosticSource bridge tests - #129704
#129704Merged
tarekgh merged 2 commits intoJun 23, 2026
dotnet:maindotnet/runtime:mainfrom
tarekgh:fix-diagnosticsource-remoteexecutor-timeouttarekgh/runtime:fix-diagnosticsource-remoteexecutor-timeoutCopy head branch name to clipboard
Merged
Increase RemoteExecutor timeout for DiagnosticSource bridge tests#129704tarekgh merged 2 commits intodotnet:maindotnet/runtime:mainfrom tarekgh:fix-diagnosticsource-remoteexecutor-timeouttarekgh/runtime:fix-diagnosticsource-remoteexecutor-timeoutCopy head branch name to clipboard
tarekgh merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
tarekgh:fix-diagnosticsource-remoteexecutor-timeouttarekgh/runtime:fix-diagnosticsource-remoteexecutor-timeoutCopy head branch name to clipboard
Conversation
The default RemoteExecutor timeout of 60 seconds is not enough on some slower CI machines, causing intermittent timeouts. Set a 3 minute timeout for all RemoteExecutor.Invoke calls in DiagnosticSourceEventSourceBridgeTests. Fixes dotnet#129687
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DiagnosticSourceEventSourceBridgeTests to use a shared RemoteInvokeOptions with an increased timeout (3 minutes) for RemoteExecutor-based subprocess tests, aiming to reduce intermittent timeouts on slower CI machines.
Changes:
- Introduces a shared
RemoteInvokeOptionsinstance withTimeOut = 180000ms. - Updates all
RemoteExecutor.Invoke(...)calls inDiagnosticSourceEventSourceBridgeTeststo pass the shared options instead of relying on the default timeout.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity |
This was referenced Jun 22, 2026
noahfalk
approved these changes
Jun 22, 2026
Member
|
fyi @mdh1418 @lateralusX |
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
…29704) The default RemoteExecutor timeout of 60 seconds is not enough on some slower CI machines, which causes intermittent timeouts in the DiagnosticSource EventSource bridge tests (for example `TestSamplingPrecedence`). This change introduces a shared `RemoteInvokeOptions` with a 3 minute timeout and applies it to all `RemoteExecutor.Invoke` calls in `DiagnosticSourceEventSourceBridgeTests` that previously relied on the default timeout. Fixes #129687 --------- Co-authored-by: Tarek Mahmoud Sayed <tarekms@ntdev.microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default RemoteExecutor timeout of 60 seconds is not enough on some slower CI machines, which causes intermittent timeouts in the DiagnosticSource EventSource bridge tests (for example
TestSamplingPrecedence).This change introduces a shared
RemoteInvokeOptionswith a 3 minute timeout and applies it to allRemoteExecutor.Invokecalls inDiagnosticSourceEventSourceBridgeTeststhat previously relied on the default timeout.Fixes #129687