[cDAC] Remove EnumerateMonitorEventWaitList implementation from DAC and cDAC - #129054
#129054Merged
barosiak merged 3 commits intoJun 10, 2026
dotnet:maindotnet/runtime:mainfrom
barosiak:barosiak/EnumerateMonitorEventWaitListbarosiak/runtime:barosiak/EnumerateMonitorEventWaitListCopy head branch name to clipboard
Merged
[cDAC] Remove EnumerateMonitorEventWaitList implementation from DAC and cDAC#129054barosiak merged 3 commits intodotnet:maindotnet/runtime:mainfrom barosiak:barosiak/EnumerateMonitorEventWaitListbarosiak/runtime:barosiak/EnumerateMonitorEventWaitListCopy head branch name to clipboard
barosiak merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
barosiak:barosiak/EnumerateMonitorEventWaitListbarosiak/runtime:barosiak/EnumerateMonitorEventWaitListCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements DacDbiImpl.EnumerateMonitorEventWaitList in the cDAC managed DacDbiImpl to enumerate threads waiting on a monitor’s condition wait list for a given object, and adds unit tests exercising key scenarios across architectures.
Changes:
- Added a cDAC implementation of
EnumerateMonitorEventWaitListthat reads theMonitor.s_conditionTable, resolves the object’sConditionviaConditionalWeakTable, maps per-thread waiter objects to threads, then walks the waiters linked list to invoke the callback. - Added
#if DEBUGvalidation comparing cDAC results against legacy DAC results. - Added unit tests covering: no sync block, null callback, missing condition / empty waiters list, and single/multiple/non-waiting thread cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs |
Adds the cDAC implementation of EnumerateMonitorEventWaitList plus DEBUG-only legacy cross-validation. |
src/native/managed/cdac/tests/UnitTests/DacDbiImplTests.cs |
Adds helper infrastructure and new tests for EnumerateMonitorEventWaitList behavior across architectures. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
max-charlamb
reviewed
Jun 8, 2026
max-charlamb
reviewed
Jun 8, 2026
noahfalk
requested changes
Jun 9, 2026
noahfalk
left a comment
Member
There was a problem hiding this comment.
I think the DAC code this was reproducing is broken and its unlikely anyone is calling the method. I'd recommend we return E_NOTIMPL rather than fix it.
This was referenced Jun 10, 2026
noahfalk
approved these changes
Jun 10, 2026
Member
Author
|
/ba-g unrelated failures |
BoyBaykiller
pushed a commit
to BoyBaykiller/runtime
that referenced
this pull request
Jun 11, 2026
…nd cDAC (dotnet#129054) ### Summary Return `E_NOTIMPL` from `EnumerateMonitorEventWaitList` in both DAC and cDAC. The underlying waiter-to-thread mapping via `Condition.t_waiterForCurrentThread` was broken (the field is cleared during `Condition.Wait`), and no current consumers are believed to call this API. Per [this review comment](dotnet#129054 (comment)) ### Changes - `dacdbiimpl.cpp` - Replace `EnumerateMonitorEventWaitList` body with `return E_NOTIMPL` - `DacDbiImpl.cs` - Replace legacy fallback delegation with `HResults.E_NOTIMPL` --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
…nd cDAC (#129054) ### Summary Return `E_NOTIMPL` from `EnumerateMonitorEventWaitList` in both DAC and cDAC. The underlying waiter-to-thread mapping via `Condition.t_waiterForCurrentThread` was broken (the field is cleared during `Condition.Wait`), and no current consumers are believed to call this API. Per [this review comment](#129054 (comment)) ### Changes - `dacdbiimpl.cpp` - Replace `EnumerateMonitorEventWaitList` body with `return E_NOTIMPL` - `DacDbiImpl.cs` - Replace legacy fallback delegation with `HResults.E_NOTIMPL` --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return
E_NOTIMPLfromEnumerateMonitorEventWaitListin both DAC and cDAC. The underlying waiter-to-thread mapping viaCondition.t_waiterForCurrentThreadwas broken (the field is cleared duringCondition.Wait), and no current consumers are believed to call this API.Per this review comment
Changes
dacdbiimpl.cpp- ReplaceEnumerateMonitorEventWaitListbody withreturn E_NOTIMPLDacDbiImpl.cs- Replace legacy fallback delegation withHResults.E_NOTIMPL