[release/9.0-staging] [TestOnly] Fix NumberFormatInfoGroupSize test - #128578
#128578Merged
tarekgh merged 2 commits intoJun 4, 2026
dotnet:release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
svick:backport/pr-120546-to-release/9.0-stagingsvick/runtime:backport/pr-120546-to-release/9.0-stagingCopy head branch name to clipboard
Merged
[release/9.0-staging] [TestOnly] Fix NumberFormatInfoGroupSize test#128578tarekgh merged 2 commits intodotnet:release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom svick:backport/pr-120546-to-release/9.0-stagingsvick/runtime:backport/pr-120546-to-release/9.0-stagingCopy head branch name to clipboard
tarekgh merged 2 commits into
dotnet:release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
svick:backport/pr-120546-to-release/9.0-stagingsvick/runtime:backport/pr-120546-to-release/9.0-stagingCopy head branch name to clipboard
Conversation
* Fix NumberFormatInfoGroupSize test * Fix coding style
Contributor
There was a problem hiding this comment.
Pull request overview
Backport of #120546 to release/9.0-staging that updates the NumberGroupSizes getter test so it accepts the new ur-IN group sizes returned by recent Apple OS globalization data, in addition to the previously expected values.
Changes:
- Expands
NumberGroupSizes_TestDatarows to include a culture name and a second acceptable expected array. - Rewrites
NumberGroupSizes_Get_ReturnsExpectedto accept either of two expected arrays, mirroring the existing pattern inNumberFormatInfoCurrencyGroupSizes. - For
ur-IN, allows bothNumberFormatInfoData.UrINNumberGroupSizes()and{ 3, 2 }as valid results.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tarekgh
approved these changes
May 26, 2026
Member
Author
|
@jeffhandley Can you approve this test-only fix for servicing? Thanks. |
Member
|
/ba-g the failures are not related to the edited tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #120546 to release/9.0-staging
/cc @jeffhandley @tarekgh
Customer Impact
This test failed in CI on 9.0: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1431345&view=ms.vss-test-web.build-test-results-tab&runId=39820274&paneView=debug&resultId=132492
Regression
Testing
Verified in main, and the failing test is occurring in release/9.0-staging as well.
Risk
Low. Test only, handling new data.